components/ui_chooser_controller.gypi - Issue 1984923002: Refactor ChooserBubbleController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ui_chooser_controller.gypi

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 # GN version: //components/browsing_data_ui	8 # GN version: //components/ui/chooser_controller

9 'target_name': 'browsing_data_ui',	9 'target_name': 'ui_chooser_controller',

10 'type': 'static_library',	10 'type': 'static_library',

11 'dependencies': [
blundell 2016/05/20 07:26:39 you need to add deps to match the GN file. you need to add deps to match the GN file. juncai 2016/05/20 20:36:11 Done. Show quoted text On 2016/05/20 07:26:39, blundell wrote: > you need to add deps to match the GN file. Done.
12 '../base/base.gyp:base',

13 'browser_sync_browser',

14 'history_core_browser',

15 ],

16 'include_dirs': [	11 'include_dirs': [

17 '..',	12 '..',

18 ],	13 ],

19 'sources': [	14 'sources': [

20 # Note: sources list duplicated in GN build.	15 # Note: sources list duplicated in GN build.

21 'browsing_data_ui/history_notice_utils.cc',	16 'ui/chooser_controller/chooser_controller.cc',

22 'browsing_data_ui/history_notice_utils.h',	17 'ui/chooser_controller/chooser_controller.h',

23 ],	18 ],

24 },	19 },

25 ],	20 ],

26 }	21 }

OLD	NEW