Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
7 7
8 #include "base/macros.h"
8 #include "components/bubble/bubble_ui.h" 9 #include "components/bubble/bubble_ui.h"
9 #include "ui/views/bubble/bubble_border.h" 10 #include "ui/views/bubble/bubble_border.h"
10 11
11 namespace views { 12 namespace views {
12 class View; 13 class View;
13 } 14 }
14 15
15 class Browser; 16 class Browser;
16 class ChooserBubbleController; 17 class ChooserController;
17 class ChooserBubbleUiViewDelegate; 18 class ChooserBubbleUiViewDelegate;
18 19
19 // ChooserBubbleUiView implements a chooser-based permission model, 20 // ChooserBubbleUiView implements a chooser-based permission model,
20 // it uses table view to show a list of items (such as usb devices, etc.) 21 // it uses table view to show a list of items (such as usb devices, etc.)
21 // for user to grant permission. It can be used by WebUsb, WebBluetooth. 22 // for user to grant permission. It can be used by the WebUSB or WebBluetooth
23 // APIs. It is owned by the BubbleController, which is owned by the
24 // BubbleManager.
22 class ChooserBubbleUiView : public BubbleUi { 25 class ChooserBubbleUiView : public BubbleUi {
23 public: 26 public:
24 ChooserBubbleUiView(Browser* browser, ChooserBubbleController* controller); 27 ChooserBubbleUiView(Browser* browser, ChooserController* controller);
25 ~ChooserBubbleUiView() override; 28 ~ChooserBubbleUiView() override;
26 29
27 // BubbleUi: 30 // BubbleUi:
28 void Show(BubbleReference bubble_reference) override; 31 void Show(BubbleReference bubble_reference) override;
29 void Close() override; 32 void Close() override;
30 void UpdateAnchorPosition() override; 33 void UpdateAnchorPosition() override;
31 34
32 private: 35 private:
33 friend class ChooserBubbleUiViewDelegate; 36 friend class ChooserBubbleUiViewDelegate;
34 views::View* GetAnchorView(); 37 views::View* GetAnchorView();
35 views::BubbleBorder::Arrow GetAnchorArrow(); 38 views::BubbleBorder::Arrow GetAnchorArrow();
36 39
37 Browser* browser_; 40 Browser* browser_; // Weak.
38 ChooserBubbleController* controller_; 41 ChooserController* controller_; // Weak.
39 ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_; 42 ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;
43
44 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiView);
40 }; 45 };
41 46
42 #endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_ 47 #endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698