Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome/browser/usb/usb_chooser_bubble_controller.h

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/usb/usb_chooser_bubble_controller.h
diff --git a/chrome/browser/usb/usb_chooser_bubble_controller.h b/chrome/browser/usb/usb_chooser_bubble_controller.h
deleted file mode 100644
index c4cc1f29d59d66054c935c6bcee605365b3d49c8..0000000000000000000000000000000000000000
--- a/chrome/browser/usb/usb_chooser_bubble_controller.h
+++ /dev/null
@@ -1,74 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_
-#define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_
-
-#include <utility>
-#include <vector>
-
-#include "base/macros.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "base/scoped_observer.h"
-#include "chrome/browser/ui/website_settings/chooser_bubble_controller.h"
-#include "components/bubble/bubble_reference.h"
-#include "device/usb/public/interfaces/chooser_service.mojom.h"
-#include "device/usb/usb_service.h"
-#include "mojo/public/cpp/bindings/array.h"
-
-namespace content {
-class RenderFrameHost;
-}
-
-namespace device {
-class UsbDevice;
-class UsbDeviceFilter;
-}
-
-// UsbChooserBubbleController creates a chooser bubble for WebUsb.
-class UsbChooserBubbleController : public ChooserBubbleController,
- public device::UsbService::Observer {
- public:
- UsbChooserBubbleController(
- content::RenderFrameHost* owner,
- mojo::Array<device::usb::DeviceFilterPtr> device_filters,
- content::RenderFrameHost* render_frame_host,
- const device::usb::ChooserService::GetPermissionCallback& callback);
- ~UsbChooserBubbleController() override;
-
- // ChooserBubbleController:
- size_t NumOptions() const override;
- const base::string16& GetOption(size_t index) const override;
- void Select(size_t index) override;
- void Cancel() override;
- void Close() override;
- GURL GetHelpCenterUrl() const override;
-
- // device::UsbService::Observer:
- void OnDeviceAdded(scoped_refptr<device::UsbDevice> device) override;
- void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override;
-
- void set_bubble_reference(BubbleReference bubble_reference);
-
- private:
- void GotUsbDeviceList(
- const std::vector<scoped_refptr<device::UsbDevice>>& devices);
- bool DisplayDevice(scoped_refptr<device::UsbDevice> device) const;
-
- content::RenderFrameHost* const render_frame_host_;
- device::usb::ChooserService::GetPermissionCallback callback_;
- ScopedObserver<device::UsbService, device::UsbService::Observer>
- usb_service_observer_;
- std::vector<device::UsbDeviceFilter> filters_;
- // Each pair is a (device, device name).
- std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>>
- devices_;
- BubbleReference bubble_reference_;
- base::WeakPtrFactory<UsbChooserBubbleController> weak_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleController);
-};
-
-#endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_
« no previous file with comments | « chrome/browser/ui/website_settings/chooser_bubble_delegate.cc ('k') | chrome/browser/usb/usb_chooser_bubble_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698