Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Side by Side Diff: chrome/browser/usb/web_usb_chooser_service.cc

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/usb/usb_chooser_controller.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/usb/web_usb_chooser_service.h" 5 #include "chrome/browser/usb/web_usb_chooser_service.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #include "chrome/browser/ui/chrome_bubble_manager.h" 10 #include "chrome/browser/ui/chrome_bubble_manager.h"
11 #include "chrome/browser/usb/usb_chooser_bubble_controller.h" 11 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"
12 #include "chrome/browser/usb/usb_chooser_controller.h"
12 #include "components/bubble/bubble_controller.h" 13 #include "components/bubble/bubble_controller.h"
13 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
14 #include "content/public/browser/render_frame_host.h" 15 #include "content/public/browser/render_frame_host.h"
15 16
16 WebUsbChooserService::WebUsbChooserService( 17 WebUsbChooserService::WebUsbChooserService(
17 content::RenderFrameHost* render_frame_host) 18 content::RenderFrameHost* render_frame_host)
18 : render_frame_host_(render_frame_host) { 19 : render_frame_host_(render_frame_host) {
19 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 20 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
20 DCHECK(render_frame_host); 21 DCHECK(render_frame_host);
21 } 22 }
22 23
23 WebUsbChooserService::~WebUsbChooserService() { 24 WebUsbChooserService::~WebUsbChooserService() {
24 for (const auto& bubble : bubbles_) { 25 for (const auto& bubble : bubbles_) {
25 if (bubble) 26 if (bubble)
26 bubble->CloseBubble(BUBBLE_CLOSE_FORCED); 27 bubble->CloseBubble(BUBBLE_CLOSE_FORCED);
27 } 28 }
28 } 29 }
29 30
30 void WebUsbChooserService::GetPermission( 31 void WebUsbChooserService::GetPermission(
31 mojo::Array<device::usb::DeviceFilterPtr> device_filters, 32 mojo::Array<device::usb::DeviceFilterPtr> device_filters,
32 const GetPermissionCallback& callback) { 33 const GetPermissionCallback& callback) {
33 content::WebContents* web_contents = 34 content::WebContents* web_contents =
34 content::WebContents::FromRenderFrameHost(render_frame_host_); 35 content::WebContents::FromRenderFrameHost(render_frame_host_);
35 Browser* browser = chrome::FindBrowserWithWebContents(web_contents); 36 Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
36 std::unique_ptr<UsbChooserBubbleController> bubble_controller( 37 std::unique_ptr<UsbChooserController> usb_chooser_controller(
37 new UsbChooserBubbleController(render_frame_host_, 38 new UsbChooserController(render_frame_host_, std::move(device_filters),
38 std::move(device_filters), 39 render_frame_host_, callback));
39 render_frame_host_, callback)); 40 std::unique_ptr<ChooserBubbleDelegate> chooser_bubble_delegate(
40 UsbChooserBubbleController* bubble_controller_ptr = bubble_controller.get(); 41 new ChooserBubbleDelegate(render_frame_host_,
41 BubbleReference bubble_reference = 42 std::move(usb_chooser_controller)));
42 browser->GetBubbleManager()->ShowBubble(std::move(bubble_controller)); 43 BubbleReference bubble_reference = browser->GetBubbleManager()->ShowBubble(
43 bubble_controller_ptr->set_bubble_reference(bubble_reference); 44 std::move(chooser_bubble_delegate));
44 bubbles_.push_back(bubble_reference); 45 bubbles_.push_back(bubble_reference);
45 } 46 }
46 47
47 void WebUsbChooserService::Bind( 48 void WebUsbChooserService::Bind(
48 mojo::InterfaceRequest<device::usb::ChooserService> request) { 49 mojo::InterfaceRequest<device::usb::ChooserService> request) {
49 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 50 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
50 bindings_.AddBinding(this, std::move(request)); 51 bindings_.AddBinding(this, std::move(request));
51 } 52 }
OLDNEW
« no previous file with comments | « chrome/browser/usb/usb_chooser_controller.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698