Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Unified Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
diff --git a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
index b3d7241d59f6a47917c579b21da8db5e32f06f5e..af98369bcd019527aec27f7b922ea2d17887fc53 100644
--- a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
+++ b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
+#include "base/macros.h"
#include "components/bubble/bubble_ui.h"
#include "ui/views/bubble/bubble_border.h"
@@ -13,15 +14,17 @@ class View;
}
class Browser;
-class ChooserBubbleController;
+class ChooserController;
class ChooserBubbleUiViewDelegate;
// ChooserBubbleUiView implements a chooser-based permission model,
// it uses table view to show a list of items (such as usb devices, etc.)
-// for user to grant permission. It can be used by WebUsb, WebBluetooth.
+// for user to grant permission. It can be used by the WebUSB or WebBluetooth
+// APIs. It is owned by the BubbleController, which is owned by the
+// BubbleManager.
class ChooserBubbleUiView : public BubbleUi {
public:
- ChooserBubbleUiView(Browser* browser, ChooserBubbleController* controller);
+ ChooserBubbleUiView(Browser* browser, ChooserController* controller);
~ChooserBubbleUiView() override;
// BubbleUi:
@@ -34,9 +37,11 @@ class ChooserBubbleUiView : public BubbleUi {
views::View* GetAnchorView();
views::BubbleBorder::Arrow GetAnchorArrow();
- Browser* browser_;
- ChooserBubbleController* controller_;
+ Browser* browser_; // Weak.
+ ChooserController* controller_; // Weak.
ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiView);
};
#endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698