Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/usb/usb_chooser_controller.h

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_CONTROLLER_H_
6 #define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_USB_USB_CHOOSER_CONTROLLER_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/scoped_observer.h" 14 #include "base/scoped_observer.h"
15 #include "chrome/browser/ui/website_settings/chooser_bubble_controller.h" 15 #include "components/chooser_controller/chooser_controller.h"
16 #include "components/bubble/bubble_reference.h"
17 #include "device/usb/public/interfaces/chooser_service.mojom.h" 16 #include "device/usb/public/interfaces/chooser_service.mojom.h"
18 #include "device/usb/usb_service.h" 17 #include "device/usb/usb_service.h"
19 #include "mojo/public/cpp/bindings/array.h" 18 #include "mojo/public/cpp/bindings/array.h"
20 19
21 namespace content { 20 namespace content {
22 class RenderFrameHost; 21 class RenderFrameHost;
23 } 22 }
24 23
25 namespace device { 24 namespace device {
26 class UsbDevice; 25 class UsbDevice;
27 class UsbDeviceFilter; 26 class UsbDeviceFilter;
28 } 27 }
29 28
30 // UsbChooserBubbleController creates a chooser bubble for WebUsb. 29 // UsbChooserController creates a chooser for WebUSB.
31 class UsbChooserBubbleController : public ChooserBubbleController, 30 // It is owned by ChooserBubbleDelegate.
32 public device::UsbService::Observer { 31 class UsbChooserController : public ChooserController,
32 public device::UsbService::Observer {
33 public: 33 public:
34 UsbChooserBubbleController( 34 UsbChooserController(
35 content::RenderFrameHost* owner, 35 content::RenderFrameHost* owner,
36 mojo::Array<device::usb::DeviceFilterPtr> device_filters, 36 mojo::Array<device::usb::DeviceFilterPtr> device_filters,
37 content::RenderFrameHost* render_frame_host, 37 content::RenderFrameHost* render_frame_host,
38 const device::usb::ChooserService::GetPermissionCallback& callback); 38 const device::usb::ChooserService::GetPermissionCallback& callback);
39 ~UsbChooserBubbleController() override; 39 ~UsbChooserController() override;
40 40
41 // ChooserBubbleController: 41 // ChooserController:
42 size_t NumOptions() const override; 42 size_t NumOptions() const override;
43 const base::string16& GetOption(size_t index) const override; 43 const base::string16& GetOption(size_t index) const override;
44 void Select(size_t index) override; 44 void Select(size_t index) override;
45 void Cancel() override; 45 void Cancel() override;
46 void Close() override; 46 void Close() override;
47 GURL GetHelpCenterUrl() const override; 47 void OpenHelpCenterUrl() const override;
48 48
49 // device::UsbService::Observer: 49 // device::UsbService::Observer:
50 void OnDeviceAdded(scoped_refptr<device::UsbDevice> device) override; 50 void OnDeviceAdded(scoped_refptr<device::UsbDevice> device) override;
51 void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override; 51 void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override;
52 52
53 void set_bubble_reference(BubbleReference bubble_reference);
54
55 private: 53 private:
56 void GotUsbDeviceList( 54 void GotUsbDeviceList(
57 const std::vector<scoped_refptr<device::UsbDevice>>& devices); 55 const std::vector<scoped_refptr<device::UsbDevice>>& devices);
58 bool DisplayDevice(scoped_refptr<device::UsbDevice> device) const; 56 bool DisplayDevice(scoped_refptr<device::UsbDevice> device) const;
59 57
60 content::RenderFrameHost* const render_frame_host_; 58 content::RenderFrameHost* const render_frame_host_;
61 device::usb::ChooserService::GetPermissionCallback callback_; 59 device::usb::ChooserService::GetPermissionCallback callback_;
62 ScopedObserver<device::UsbService, device::UsbService::Observer> 60 ScopedObserver<device::UsbService, device::UsbService::Observer>
63 usb_service_observer_; 61 usb_service_observer_;
64 std::vector<device::UsbDeviceFilter> filters_; 62 std::vector<device::UsbDeviceFilter> filters_;
65 // Each pair is a (device, device name). 63 // Each pair is a (device, device name).
66 std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>> 64 std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>>
67 devices_; 65 devices_;
68 BubbleReference bubble_reference_; 66 base::WeakPtrFactory<UsbChooserController> weak_factory_;
69 base::WeakPtrFactory<UsbChooserBubbleController> weak_factory_;
70 67
71 DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleController); 68 DISALLOW_COPY_AND_ASSIGN(UsbChooserController);
72 }; 69 };
73 70
74 #endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_CONTROLLER_H_ 71 #endif // CHROME_BROWSER_USB_USB_CHOOSER_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/usb/usb_chooser_bubble_controller.cc ('k') | chrome/browser/usb/usb_chooser_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698