components/ui/chooser_controller/README - Issue 1984923002: Refactor ChooserBubbleController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ui/chooser_controller/README

Issue 1984923002: Refactor ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This directory contains an interface for a chooser controller which has

	2 a list of options that users can pick one of.

	3

	4 Here is the diagram of classes which use ChooserController.
	blundell 2016/05/20 07:26:39 Are these classes going to end up in this componen Are these classes going to end up in this component? If not, it seems like a layering violation to reference them in this README. juncai 2016/05/20 20:36:11 These classes are not in this component. Removed f Show quoted text On 2016/05/20 07:26:39, blundell wrote: > Are these classes going to end up in this component? If not, it seems like a > layering violation to reference them in this README. These classes are not in this component. Removed from README. Done.
	5

	6 ChooserController BubbleDelegate

	7 ^ ^

	8 \| \|

	9 ----------------------

	10 \|

	11 ChooserBubbleController device::UsbService::Observer

	12 ^ ^ ^

	13 \| \| \|

	14 \| -----------------------------

	15 \| \|

	16 BluetoothChooserBubbleController UsbChooserBubbleController

OLD	NEW