Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
ojan, jam, mithro
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert all of the run-webkit-test wrapper changes from this weekend. We probably want to keep some variant of this code in, but such a decision should be properly reviewed (and tested across platforms). For now, this CL backs out the changes I landed over the previous few days (except for the src-side change to run-webkit-tests that added the --json-test-results flag; that change was simple, harmless, and will be needed if we end up wanting these changes). TBR=tansell@chromium.org, jam@chromium.org, ojan@chromium.org BUG=522396 This reverts commit e81f2296279d56342be5be503bc1322ce1778c78. Revert "Call run-webkit-tests directly on windows." This reverts commit fea188005db5f9d19ac15381721a0fa75209e31d. Revert "Fix command line arg passed to run-webkit-tests" This reverts commit d1d2df9ecbda3c8d66bdfd2b7003b646ebbf805c. Revert "Tweak invocation of run-webkit-tests to fix bugs." This reverts commit 6964e8331716a59206aaaed1b67686cd1fc0fad4. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -129 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 4 chunks +30 lines, -12 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7__dbg_.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 4 chunks +30 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 4 chunks +30 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json View 2 chunks +15 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json View 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dirk Pranke
4 years, 7 months ago (2016-05-01 22:26:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936943002/1
4 years, 7 months ago (2016-05-01 22:26:54 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:31:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300389

Powered by Google App Engine
This is Rietveld 408576698