scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json - Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json

diff --git a/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json

index 966e8f5d0cad35a3e42ab1cd14eab81ffaac17f6..4254c65418e54d5e208c702aa2d236531c8c9d11 100644

--- a/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json

+++ b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json

@@ -280,10 +280,22 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",

+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",

"--target",

"Release",

- "--results-directory",

+ "--factory-properties",

+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"WebKit Win7\", \"buildnumber\": 571, \"mastername\": \"chromium.webkit\", \"parent_buildername\": \"WebKit Win Builder\", \"parent_got_revision\": \"7496f63cbefd34b2d791022fbad64a82838a3f3f\", \"parent_got_webkit_revision\": \"191275\", \"project\": \"webkit\", \"recipe\": \"chromium\", \"revision\": \"191275\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",

+ "--build-properties",

+ "--step-name=webkit_tests",

+ "--builder-name=WebKit Win7",

+ "--slave-name=TestSlavename",

+ "--build-number=571",

+ "--run-python-script",

+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",

+ "--target",

+ "Release",

+ "-o",

"[SLAVE_BUILD]\\layout-test-results",

"--build-dir",

"[SLAVE_BUILD]\\src\\out",

@@ -296,10 +308,7 @@

"--builder-name",

"WebKit Win7",

"--step-name",

- "webkit_tests",

- "--master-name",

- "chromium.webkit",

- "--debug-rwt-logging"

+ "webkit_tests"

"name": "webkit_tests",

"~followup_annotations": [