scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json - Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json ('k') | scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

diff --git a/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

index 2a608fb9ced659b3422a73bbb3a0e92aac366e57..1000c6b037791fb1c29054b082c20ab0a773a8a6 100644

--- a/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

+++ b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json

@@ -176,10 +176,22 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",

+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",

"--target",

"Release",

- "--results-directory",

+ "--factory-properties",

+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8-Blink Win\", \"buildnumber\": 571, \"mastername\": \"client.v8.fyi\", \"recipe\": \"blink_downstream\", \"revision\": \"20123\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",

+ "--build-properties",

+ "--step-name=webkit_tests (with patch)",

+ "--builder-name=V8-Blink Win",

+ "--slave-name=TestSlavename",

+ "--build-number=571",

+ "--run-python-script",

+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",

+ "--target",

+ "Release",

+ "-o",

"[SLAVE_BUILD]\\layout-test-results",

"--build-dir",

"[SLAVE_BUILD]\\src\\out",

@@ -195,10 +207,7 @@

"webkit_tests (with patch)",

"--no-pixel-tests",

"--additional-expectations",

- "[SLAVE_BUILD]\\src\\v8\\tools\\blink_tests\\TestExpectations",

- "--master-name",

- "client.v8.fyi",

- "--debug-rwt-logging"

+ "[SLAVE_BUILD]\\src\\v8\\tools\\blink_tests\\TestExpectations"

"name": "webkit_tests (with patch)",

"~followup_annotations": [