Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
diff --git a/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
index 0f9a867eab128930b000bda3e16fbad76dd5bfa2..c96c2e494671dc33edefc10d72b3b5eb5c2fe6c9 100644
--- a/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
+++ b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
@@ -176,10 +176,22 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",
+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",
+ "--target",
+ "Release",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8-Blink Win\", \"buildnumber\": 571, \"mastername\": \"client.v8.fyi\", \"recipe\": \"blink_downstream\", \"revision\": \"20123\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8-Blink Win\", \"buildnumber\": 571, \"mastername\": \"client.v8.fyi\", \"recipe\": \"blink_downstream\", \"revision\": \"20123\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--step-name=webkit_tests (with patch)",
+ "--builder-name=V8-Blink Win",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "--run-python-script",
+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",
"--target",
"Release",
- "--results-directory",
+ "-o",
"[SLAVE_BUILD]\\layout-test-results",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
@@ -195,10 +207,7 @@
"webkit_tests (with patch)",
"--no-pixel-tests",
"--additional-expectations",
- "[SLAVE_BUILD]\\src\\v8\\tools\\blink_tests\\TestExpectations",
- "--master-name",
- "client.v8.fyi",
- "--debug-rwt-logging"
+ "[SLAVE_BUILD]\\src\\v8\\tools\\blink_tests\\TestExpectations"
],
"name": "webkit_tests (with patch)",
"~followup_annotations": [
@@ -372,10 +381,22 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",
+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",
"--target",
"Release",
- "--results-directory",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8-Blink Win\", \"buildnumber\": 571, \"mastername\": \"client.v8.fyi\", \"recipe\": \"blink_downstream\", \"revision\": \"20123\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8-Blink Win\", \"buildnumber\": 571, \"mastername\": \"client.v8.fyi\", \"recipe\": \"blink_downstream\", \"revision\": \"20123\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--step-name=webkit_tests (without patch)",
+ "--builder-name=V8-Blink Win",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "--run-python-script",
+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",
+ "--target",
+ "Release",
+ "-o",
"[SLAVE_BUILD]\\layout-test-results",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
@@ -395,10 +416,7 @@
"--test-list",
"bad/totally-bad-probably.html\ntricky/totally-maybe-not-awesome.html",
"--skipped",
- "always",
- "--master-name",
- "client.v8.fyi",
- "--debug-rwt-logging"
+ "always"
],
"name": "webkit_tests (without patch)",
"~followup_annotations": [

Powered by Google App Engine
This is Rietveld 408576698