scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json - Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend.

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json b/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json

index ee62e435f0882b293f4504bfe563c8f0dd6b53f5..0d228e67bd009932c5d516c0ab0a6ea6cb7d1786 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json

@@ -388,10 +388,22 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",

+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",

"--target",

"Release",

- "--results-directory",

+ "--factory-properties",

+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"build_data_dir\": \"[ROOT]\\\\build_data_dir\", \"buildername\": \"WebKit Win10\", \"buildnumber\": 571, \"gs_acl\": \"public-read\", \"mastername\": \"chromium.webkit\", \"parent_build_archive_url\": \"gs://test-domain/test-archive.zip\", \"parent_buildername\": \"WebKit Win Builder\", \"parent_got_revision\": \"1111111\", \"recipe\": \"chromium\", \"slavename\": \"TestSlavename\", \"swarm_hashes\": {\"browser_tests\": \"ffffffffffffffffffffffffffffffffffffffff\"}, \"workdir\": \"/path/to/workdir/TestSlavename\"}",

+ "--build-properties",

+ "--step-name=webkit_tests",

+ "--builder-name=WebKit Win10",

+ "--slave-name=TestSlavename",

+ "--build-number=571",

+ "--run-python-script",

+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",

+ "--target",

+ "Release",

+ "-o",

"[SLAVE_BUILD]\\layout-test-results",

"--build-dir",

"[SLAVE_BUILD]\\src\\out",

@@ -404,10 +416,7 @@

"--builder-name",

"WebKit Win10",

"--step-name",

- "webkit_tests",

- "--master-name",

- "chromium.webkit",

- "--debug-rwt-logging"

+ "webkit_tests"

"name": "webkit_tests",

"~followup_annotations": [