Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
diff --git a/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json b/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
index 21b3298681b24cd7c72ce6c46e12a58fe16a22af..da64c1244dd9524e33349722c285ef584ee5b608 100644
--- a/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
+++ b/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
@@ -473,10 +473,22 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",
+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",
"--target",
"Release",
- "--results-directory",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"win_chromium_rel_ng\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.win\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_trybot\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"swarm_hashes\": {}, \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"win_chromium_rel_ng\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.win\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_trybot\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"swarm_hashes\": {}, \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--step-name=webkit_tests (with patch)",
+ "--builder-name=win_chromium_rel_ng",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "--run-python-script",
+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",
+ "--target",
+ "Release",
+ "-o",
"[SLAVE_BUILD]\\layout-test-results",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
@@ -489,10 +501,7 @@
"--builder-name",
"win_chromium_rel_ng",
"--step-name",
- "webkit_tests (with patch)",
- "--master-name",
- "tryserver.chromium.win",
- "--debug-rwt-logging"
+ "webkit_tests (with patch)"
],
"name": "webkit_tests (with patch)",
"~followup_annotations": [

Powered by Google App Engine
This is Rietveld 408576698