Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 import string 6 import string
7 7
8 8
9 class Test(object): 9 class Test(object):
10 """ 10 """
(...skipping 1680 matching lines...) Expand 10 before | Expand all | Expand 10 after
1691 if api.chromium.c.TARGET_PLATFORM == 'android': 1691 if api.chromium.c.TARGET_PLATFORM == 'android':
1692 args.extend(['--platform', 'android']) 1692 args.extend(['--platform', 'android'])
1693 if self._extra_args: 1693 if self._extra_args:
1694 args.extend(self._extra_args) 1694 args.extend(self._extra_args)
1695 if suffix == 'without patch': 1695 if suffix == 'without patch':
1696 test_list = "\n".join(self.failures(api, 'with patch')) 1696 test_list = "\n".join(self.failures(api, 'with patch'))
1697 args.extend(['--test-list', api.raw_io.input(test_list), 1697 args.extend(['--test-list', api.raw_io.input(test_list),
1698 '--skipped', 'always']) 1698 '--skipped', 'always'])
1699 1699
1700 try: 1700 try:
1701 if api.platform.is_win: 1701 step_result = api.chromium.runtest(
1702 args[2] = '--results-directory'
1703 args += [
1704 '--master-name', api.properties['mastername'],
1705 '--debug-rwt-logging',
1706 ]
1707 step_result = api.python(
1708 step_name,
1709 api.path['checkout'].join('third_party', 'WebKit', 'Tools',
1710 'Scripts', 'run-webkit-tests'),
1711 args,
1712 step_test_data=lambda: api.test_utils.test_api.canned_test_output(
1713 passing=True, minimal=True))
1714 else:
1715 step_result = api.chromium.runtest(
1716 api.path['build'].join('scripts', 'slave', 'chromium', 1702 api.path['build'].join('scripts', 'slave', 'chromium',
1717 'layout_test_wrapper.py'), 1703 'layout_test_wrapper.py'),
1718 args, name=step_name, 1704 args, name=step_name,
1719 # TODO(phajdan.jr): Clean up the runtest.py mess. 1705 # TODO(phajdan.jr): Clean up the runtest.py mess.
1720 disable_src_side_runtest_py=True, 1706 disable_src_side_runtest_py=True,
1721 step_test_data=lambda: api.test_utils.test_api.canned_test_output( 1707 step_test_data=lambda: api.test_utils.test_api.canned_test_output(
1722 passing=True, minimal=True)) 1708 passing=True, minimal=True))
1723 1709
1724 # Mark steps with unexpected flakes as warnings. Do this here instead of 1710 # Mark steps with unexpected flakes as warnings. Do this here instead of
1725 # "finally" blocks because we only want to do this if step was successful. 1711 # "finally" blocks because we only want to do this if step was successful.
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1861 def run(self, api, suffix, test_filter=None): 1847 def run(self, api, suffix, test_filter=None):
1862 api.chromium_android.coverage_report(upload=False) 1848 api.chromium_android.coverage_report(upload=False)
1863 api.chromium_android.get_changed_lines_for_revision() 1849 api.chromium_android.get_changed_lines_for_revision()
1864 api.chromium_android.incremental_coverage_report() 1850 api.chromium_android.incremental_coverage_report()
1865 1851
1866 1852
1867 GOMA_TESTS = [ 1853 GOMA_TESTS = [
1868 GTestTest('base_unittests'), 1854 GTestTest('base_unittests'),
1869 GTestTest('content_unittests'), 1855 GTestTest('content_unittests'),
1870 ] 1856 ]
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698