scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index 50218af2fda0eaf82bfbba227d7a2e499fa32555..b11561663fa7b05b6f31a3a0b5d67cc438c4a388 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -1698,21 +1698,7 @@ class BlinkTest(Test):

'--skipped', 'always'])

try:

- if api.platform.is_win:

- args[2] = '--results-directory'

- args += [

- '--master-name', api.properties['mastername'],

- '--debug-rwt-logging',

- ]

- step_result = api.python(

- step_name,

- api.path['checkout'].join('third_party', 'WebKit', 'Tools',

- 'Scripts', 'run-webkit-tests'),

- args,

- step_test_data=lambda: api.test_utils.test_api.canned_test_output(

- passing=True, minimal=True))

- else:

- step_result = api.chromium.runtest(

+ step_result = api.chromium.runtest(

api.path['build'].join('scripts', 'slave', 'chromium',

'layout_test_wrapper.py'),

args, name=step_name,

« no previous file with comments | « no previous file | scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json » ('j') | no next file with comments »