Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json

Issue 1936943002: Revert all of the run-webkit-test wrapper changes from this weekend. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
diff --git a/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
index e35cda5635892fe6d21aacee306a4b20b8a571d6..ff109d4f81c06e78699d353a5c234848e59bd63e 100644
--- a/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
+++ b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
@@ -280,10 +280,22 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]\\src\\third_party\\WebKit\\Tools\\Scripts\\run-webkit-tests",
+ "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\runtest.py",
"--target",
"Release",
- "--results-directory",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"WebKit Win7\", \"buildnumber\": 571, \"mastername\": \"chromium.webkit\", \"parent_buildername\": \"WebKit Win Builder\", \"parent_got_revision\": \"1e74b372f951d4491f305ec64f6decfcda739e73\", \"parent_got_webkit_revision\": \"191269\", \"project\": \"chromium\", \"recipe\": \"chromium\", \"revision\": \"1e74b372f951d4491f305ec64f6decfcda739e73\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"WebKit Win7\", \"buildnumber\": 571, \"mastername\": \"chromium.webkit\", \"parent_buildername\": \"WebKit Win Builder\", \"parent_got_revision\": \"1e74b372f951d4491f305ec64f6decfcda739e73\", \"parent_got_webkit_revision\": \"191269\", \"project\": \"chromium\", \"recipe\": \"chromium\", \"revision\": \"1e74b372f951d4491f305ec64f6decfcda739e73\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--step-name=webkit_tests",
+ "--builder-name=WebKit Win7",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "--run-python-script",
+ "[BUILD]\\scripts\\slave\\chromium\\layout_test_wrapper.py",
+ "--target",
+ "Release",
+ "-o",
"[SLAVE_BUILD]\\layout-test-results",
"--build-dir",
"[SLAVE_BUILD]\\src\\out",
@@ -296,10 +308,7 @@
"--builder-name",
"WebKit Win7",
"--step-name",
- "webkit_tests",
- "--master-name",
- "chromium.webkit",
- "--debug-rwt-logging"
+ "webkit_tests"
],
"name": "webkit_tests",
"~followup_annotations": [

Powered by Google App Engine
This is Rietveld 408576698