Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Eric Willigers, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. BUG=580337 Committed: https://crrev.com/b6864f2831ba527681322bc99d60c18f527f85c4 Cr-Commit-Position: refs/heads/master@{#390588}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -153 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 4 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 2 chunks +39 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 3 chunks +20 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 4 chunks +5 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-04-27 22:32:27 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-04-28 01:24:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663006/1
4 years, 7 months ago (2016-04-28 19:45:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/26872) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-04-28 19:48:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663006/20001
4 years, 7 months ago (2016-04-28 23:51:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/205897) win_clang on tryserver.chromium.win (JOB_FAILED, ...
4 years, 7 months ago (2016-04-29 00:16:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663006/20001
4 years, 7 months ago (2016-04-29 00:19:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/205912)
4 years, 7 months ago (2016-04-29 01:09:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924663006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924663006/20001
4 years, 7 months ago (2016-04-29 01:17:32 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 03:42:35 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:12 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6864f2831ba527681322bc99d60c18f527f85c4
Cr-Commit-Position: refs/heads/master@{#390588}

Powered by Google App Engine
This is Rietveld 408576698