third_party/WebKit/Source/core/inspector/PageConsoleAgent.h - Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

index 1fe4e4140fdf9457ca9a79cc58f4241b13912bfc..666eb8adcb4f099f791e5fba0d618e1b6543bd8a 100644

--- a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

+++ b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

@@ -47,10 +47,7 @@ class WorkerGlobalScopeProxy;

class CORE_EXPORT PageConsoleAgent final : public InspectorConsoleAgent {

WTF_MAKE_NONCOPYABLE(PageConsoleAgent);

public:

- static PageConsoleAgent* create(V8RuntimeAgent* runtimeAgent, InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames)

- {

- return new PageConsoleAgent(runtimeAgent, domAgent, inspectedFrames);

- }

+ PageConsoleAgent(V8InspectorSession*, InspectorDOMAgent*, InspectedFrames*);

~PageConsoleAgent() override;

DECLARE_VIRTUAL_TRACE();

@@ -69,7 +66,6 @@ protected:

void disableStackCapturingIfNeeded() override;

private:

- PageConsoleAgent(V8RuntimeAgent*, InspectorDOMAgent*, InspectedFrames*);

void clearMessages(ErrorString*) override;

Member<InspectorDOMAgent> m_inspectorDOMAgent;