third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index 355b2499ebe00c4edf5935411653310cb8c492ac..d80a4b63d16c4a19ff6e9ff83ea57e373345db09 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -26,7 +26,7 @@

#include "core/inspector/InspectorStyleSheet.h"

#include "platform/Decimal.h"

#include "platform/animation/TimingFunction.h"

-#include "platform/v8_inspector/public/V8RuntimeAgent.h"

+#include "platform/v8_inspector/public/V8InspectorSession.h"

#include "wtf/text/Base64.h"

namespace AnimationAgentState {

@@ -36,12 +36,12 @@ static const char animationAgentPlaybackRate[] = "animationAgentPlaybackRate";

namespace blink {

-InspectorAnimationAgent::InspectorAnimationAgent(InspectedFrames* inspectedFrames, InspectorDOMAgent* domAgent, InspectorCSSAgent* cssAgent, V8RuntimeAgent* runtimeAgent)

+InspectorAnimationAgent::InspectorAnimationAgent(InspectedFrames* inspectedFrames, InspectorDOMAgent* domAgent, InspectorCSSAgent* cssAgent, V8InspectorSession* v8Session)

: InspectorBaseAgent<InspectorAnimationAgent, protocol::Frontend::Animation>("Animation")

, m_inspectedFrames(inspectedFrames)

, m_domAgent(domAgent)

, m_cssAgent(cssAgent)

- , m_runtimeAgent(runtimeAgent)

+ , m_v8Session(v8Session)

, m_isCloning(false)

{

}

@@ -380,8 +380,8 @@ void InspectorAnimationAgent::resolveAnimation(ErrorString* errorString, const S

}

ScriptState::Scope scope(scriptState);

- m_runtimeAgent->disposeObjectGroup("animation");

- *result = m_runtimeAgent->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), "animation");

+ m_v8Session->releaseObjectGroup("animation");

+ *result = m_v8Session->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), "animation");

if (!*result)

*errorString = "Element not associated with a document.";

}