Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h
index 042a4e75781cfbb5c74acadbcedd909fa8d2b24d..917114f42bcfee63e4df73ab6068692d9809981e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h
@@ -7,33 +7,15 @@
#include "platform/PlatformExport.h"
#include "platform/inspector_protocol/Dispatcher.h"
-#include "platform/v8_inspector/public/V8ContextInfo.h"
#include "platform/v8_inspector/public/V8Debugger.h"
-#include <v8.h>
-
namespace blink {
class InjectedScriptManager;
class PLATFORM_EXPORT V8RuntimeAgent : public protocol::Backend::Runtime, public V8Debugger::Agent<protocol::Frontend::Runtime> {
public:
- // Cross-context inspectable values (DOM nodes in different worlds, etc.).
- class Inspectable {
- public:
- virtual v8::Local<v8::Value> get(v8::Local<v8::Context>) = 0;
- virtual ~Inspectable() { }
- };
-
virtual ~V8RuntimeAgent() { }
-
- // Embedder API.
- virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) = 0;
- // FIXME: remove when InspectorConsoleAgent moves into V8 inspector.
- virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) = 0;
- virtual v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;
- virtual void disposeObjectGroup(const String16&) = 0;
- virtual void addInspectedObject(PassOwnPtr<Inspectable>) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698