Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
index 34b6ea65e74824f4699754a826b39ac2025bc8a6..68227750a8736d2dff753064540a0ce2bd5b95c0 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
@@ -383,53 +383,6 @@ void V8RuntimeAgentImpl::disable(ErrorString* errorString)
m_session->changeInstrumentationCounter(-1);
}
-PassOwnPtr<RemoteObject> V8RuntimeAgentImpl::wrapObject(v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& groupName, bool generatePreview)
-{
- ErrorString errorString;
- InjectedScript* injectedScript = m_session->findInjectedScript(&errorString, V8Debugger::contextId(context));
- if (!injectedScript)
- return nullptr;
- return injectedScript->wrapObject(&errorString, value, groupName, false, generatePreview);
-}
-
-PassOwnPtr<RemoteObject> V8RuntimeAgentImpl::wrapTable(v8::Local<v8::Context> context, v8::Local<v8::Value> table, v8::Local<v8::Value> columns)
-{
- ErrorString errorString;
- InjectedScript* injectedScript = m_session->findInjectedScript(&errorString, V8Debugger::contextId(context));
- if (!injectedScript)
- return nullptr;
- return injectedScript->wrapTable(table, columns);
-}
-
-void V8RuntimeAgentImpl::disposeObjectGroup(const String16& groupName)
-{
- m_session->releaseObjectGroup(groupName);
-}
-
-v8::Local<v8::Value> V8RuntimeAgentImpl::findObject(ErrorString* errorString, const String16& objectId, v8::Local<v8::Context>* context, String16* groupName)
-{
- OwnPtr<RemoteObjectId> remoteId = RemoteObjectId::parse(errorString, objectId);
- if (!remoteId)
- return v8::Local<v8::Value>();
- InjectedScript* injectedScript = m_session->findInjectedScript(errorString, remoteId.get());
- if (!injectedScript)
- return v8::Local<v8::Value>();
- v8::Local<v8::Value> objectValue;
- injectedScript->findObject(errorString, *remoteId, &objectValue);
- if (objectValue.IsEmpty())
- return v8::Local<v8::Value>();
- if (context)
- *context = injectedScript->context()->context();
- if (groupName)
- *groupName = injectedScript->objectGroupName(*remoteId);
- return objectValue;
-}
-
-void V8RuntimeAgentImpl::addInspectedObject(PassOwnPtr<Inspectable> inspectable)
-{
- m_session->addInspectedObject(std::move(inspectable));
-}
-
void V8RuntimeAgentImpl::reset()
{
m_compiledScripts.clear();

Powered by Google App Engine
This is Rietveld 408576698