Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1907663005
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Rework idle{Started,Finished} instrumentation. Idle state is global on isolate, so instrumentation goes through V8Debugger. BUG=580337 Committed: https://crrev.com/c856072bb33c87f752124ef92e9bdb84d12c1c1f Cr-Commit-Position: refs/heads/master@{#392472}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased, added missing space #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -72 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 1 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1924663006 Patch 20001

Dependent Patchsets:

Issue 1933573002 Patch 1

Messages

Total messages: 23 (11 generated)
dgozman
Could you please take a look?
4 years, 8 months ago (2016-04-23 00:47:41 UTC) #2
alph
lgtm https://codereview.chromium.org/1913283003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/1913283003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode56 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:56: void ThreadDebugger::idleFinished(v8::Isolate*isolate) nit: missing space
4 years, 8 months ago (2016-04-23 01:46:49 UTC) #3
dgozman
https://codereview.chromium.org/1913283003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/1913283003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode56 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:56: void ThreadDebugger::idleFinished(v8::Isolate*isolate) On 2016/04/23 01:46:49, alph wrote: > nit: ...
4 years, 8 months ago (2016-04-25 21:30:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283003/20001
4 years, 8 months ago (2016-04-25 21:32:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/160194)
4 years, 8 months ago (2016-04-25 22:20:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283003/40001
4 years, 7 months ago (2016-04-29 04:46:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/162714)
4 years, 7 months ago (2016-04-29 05:29:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283003/40001
4 years, 7 months ago (2016-04-29 17:10:00 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/220007)
4 years, 7 months ago (2016-04-29 18:41:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283003/40001
4 years, 7 months ago (2016-05-09 22:08:20 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-09 23:34:08 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:35:16 UTC) #23
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c856072bb33c87f752124ef92e9bdb84d12c1c1f
Cr-Commit-Position: refs/heads/master@{#392472}

Powered by Google App Engine
This is Rietveld 408576698