Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h
index c278704021b78eece7529061870acc7211716829..c562f63b8da5b5386e3dfb48187a9c6982b7bd25 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h
@@ -21,15 +21,12 @@ class InspectedFrames;
class InspectorCSSAgent;
class InspectorDOMAgent;
class TimingFunction;
-class V8RuntimeAgent;
+class V8InspectorSession;
class CORE_EXPORT InspectorAnimationAgent final : public InspectorBaseAgent<InspectorAnimationAgent, protocol::Frontend::Animation>, public protocol::Backend::Animation {
WTF_MAKE_NONCOPYABLE(InspectorAnimationAgent);
public:
- static InspectorAnimationAgent* create(InspectedFrames* inspectedFrames, InspectorDOMAgent* domAgent, InspectorCSSAgent* cssAgent, V8RuntimeAgent* runtimeAgent)
- {
- return new InspectorAnimationAgent(inspectedFrames, domAgent, cssAgent, runtimeAgent);
- }
+ InspectorAnimationAgent(InspectedFrames*, InspectorDOMAgent*, InspectorCSSAgent*, V8InspectorSession*);
// Base agent methods.
void restore() override;
@@ -58,8 +55,6 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- InspectorAnimationAgent(InspectedFrames*, InspectorDOMAgent*, InspectorCSSAgent*, V8RuntimeAgent*);
-
using AnimationType = protocol::Animation::Animation::TypeEnum;
PassOwnPtr<protocol::Animation::Animation> buildObjectForAnimation(blink::Animation&);
@@ -72,7 +67,7 @@ private:
Member<InspectedFrames> m_inspectedFrames;
Member<InspectorDOMAgent> m_domAgent;
Member<InspectorCSSAgent> m_cssAgent;
- V8RuntimeAgent* m_runtimeAgent;
+ V8InspectorSession* m_v8Session;
HeapHashMap<String, Member<blink::Animation>> m_idToAnimation;
HeapHashMap<String, Member<blink::Animation>> m_idToAnimationClone;
HashMap<String, String> m_idToAnimationType;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698