third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h - Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h

index c63eade189dd1d3a5ca00524640094c5aebdf3fa..5587c4696bd9c2429cee852e88622242e66190d1 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h

@@ -34,12 +34,11 @@ namespace blink {

class ConsoleMessage;

class ConsoleMessageStorage;

-class V8RuntimeAgent;

+class V8InspectorSession;

class CORE_EXPORT InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent, protocol::Frontend::Console>, public protocol::Backend::Console {

WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent);

public:

- InspectorConsoleAgent(V8RuntimeAgent*);

~InspectorConsoleAgent() override;

void enable(ErrorString*) override;

@@ -52,13 +51,14 @@ public:

virtual void consoleMessagesCleared();

protected:

+ explicit InspectorConsoleAgent(V8InspectorSession*);

void sendConsoleMessageToFrontend(ConsoleMessage*, bool generatePreview);

virtual ConsoleMessageStorage* messageStorage() = 0;

virtual void enableStackCapturingIfNeeded() = 0;

virtual void disableStackCapturingIfNeeded() = 0;

- V8RuntimeAgent* m_runtimeAgent;

+ V8InspectorSession* m_v8Session;

bool m_enabled;

};