Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 1924663006: [DevTools] Move API methods from V8RuntimeAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger-into-session
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
index 2bfea6f476603f383ed50d18d2461151887bebde..6e069e8c4d4ce0abf5136710a71ef301b328d1c5 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
@@ -37,7 +37,7 @@
#include "core/style/ComputedStyleConstants.h"
#include "platform/geometry/FloatQuad.h"
#include "platform/inspector_protocol/Values.h"
-#include "platform/v8_inspector/public/V8RuntimeAgent.h"
+#include "platform/v8_inspector/public/V8InspectorSession.h"
#include "wtf/HashMap.h"
#include "wtf/HashSet.h"
@@ -94,15 +94,11 @@ public:
virtual void setInspectedNode(Node*) { }
};
- static InspectorDOMAgent* create(v8::Isolate* isolate, InspectedFrames* inspectedFrames, V8RuntimeAgent* runtimeAgent, Client* client)
- {
- return new InspectorDOMAgent(isolate, inspectedFrames, runtimeAgent, client);
- }
-
static String toErrorString(ExceptionState&);
static bool getPseudoElementType(PseudoId, String*);
static ShadowRoot* userAgentShadowRoot(Node*);
+ InspectorDOMAgent(v8::Isolate*, InspectedFrames*, V8InspectorSession*, Client*);
~InspectorDOMAgent() override;
DECLARE_VIRTUAL_TRACE();
@@ -200,8 +196,6 @@ public:
Document* assertDocument(ErrorString*, int nodeId);
private:
- InspectorDOMAgent(v8::Isolate*, InspectedFrames*, V8RuntimeAgent*, Client*);
-
void setDocument(Document*);
void innerEnable();
@@ -242,7 +236,7 @@ private:
v8::Isolate* m_isolate;
Member<InspectedFrames> m_inspectedFrames;
- V8RuntimeAgent* m_runtimeAgent;
+ V8InspectorSession* m_v8Session;
Client* m_client;
Member<DOMListener> m_domListener;
Member<NodeToIdMap> m_documentNodeToIdMap;

Powered by Google App Engine
This is Rietveld 408576698