Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1881513002: Add appendPrecisionModifier method to GrGLSLShaderBuilder (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -43 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +16 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 2 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Chris Dalton
What do you think? It's a bit bikeshed-y but I think it helps clean things ...
4 years, 8 months ago (2016-04-11 16:57:26 UTC) #2
Chris Dalton
4 years, 8 months ago (2016-04-11 16:57:45 UTC) #4
bsalomon
lgtm
4 years, 8 months ago (2016-04-11 18:15:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881513002/1
4 years, 8 months ago (2016-04-11 18:18:16 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:30:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1f50acff0dc09e50cc207846508d8e6459334b2a

Powered by Google App Engine
This is Rietveld 408576698