Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1878943003: Remove RawPtr from bindings/ (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RawPtr from bindings/ BUG=585328 Committed: https://crrev.com/1a7d8e92dc21d3b58ab778c7997397466c8af1e1 Cr-Commit-Position: refs/heads/master@{#386621}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -100 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 5 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h View 1 chunk +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +3 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 2 chunks +3 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
keishi
PTAL
4 years, 8 months ago (2016-04-12 07:07:03 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-12 07:07:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878943003/20001
4 years, 8 months ago (2016-04-12 07:08:27 UTC) #6
sof
https://codereview.chromium.org/1878943003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h File third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h (right): https://codereview.chromium.org/1878943003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h#newcode98 third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h:98: V8EventListener* wrapperPtr = WrapperType::create(object, isAttribute, scriptState); (nit: could just ...
4 years, 8 months ago (2016-04-12 07:29:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 08:16:59 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:18:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a7d8e92dc21d3b58ab778c7997397466c8af1e1
Cr-Commit-Position: refs/heads/master@{#386621}

Powered by Google App Engine
This is Rietveld 408576698