third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h - Issue 1878943003: Remove RawPtr from bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

index 8be789dc692ae9edd4f1e2e1c3aa946135f1286e..cc137a1c9ed83f4888fd128e72e0c7449bd6b957 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

@@ -80,11 +80,6 @@ public:

// even if the user script is not compilable.

v8::Local<v8::Object> getListenerObject(ExecutionContext* executionContext)

{

- // prepareListenerObject can potentially deref this event listener

- // as it may attempt to compile a function (lazy event listener), get an error

- // and invoke onerror callback which can execute arbitrary JS code.

- // Protect this event listener to keep it alive.

- RawPtr<V8AbstractEventListener> protect(this);

prepareListenerObject(executionContext);

return m_listener.newLocal(m_isolate);

}