third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp - Issue 1878943003: Remove RawPtr from bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

index ef310eff27f50a1f0fc070a3e54c2a74bc03fbca..957164141e68aed3ce72ba4a407b649f0919037e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

@@ -21,8 +21,8 @@ void pagePopupControllerAttributeGetter(const v8::PropertyCallbackInfo<v8::Value

{

v8::Local<v8::Object> holder = info.Holder();

DOMWindow* impl = V8Window::toImpl(holder);

- RawPtr<PagePopupController> cppValue(PagePopupSupplement::pagePopupController(*toLocalDOMWindow(impl)->frame()));

- v8SetReturnValue(info, toV8(cppValue.get(), holder, info.GetIsolate()));

+ PagePopupController* cppValue = PagePopupSupplement::pagePopupController(*toLocalDOMWindow(impl)->frame());

+ v8SetReturnValue(info, toV8(cppValue, holder, info.GetIsolate()));

}

void pagePopupControllerAttributeGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info)