Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 78b5f7d8adad4833eecca646921c93d4c1a14951..6a6b38ec6cad710af4be471c3d9aec648b597be2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -192,7 +192,7 @@ void V8Window::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>
// postMessage(message, targetOrigin, {sequence of transferrables})
// Legacy non-standard implementations in webkit allowed:
// postMessage(message, {sequence of transferrables}, targetOrigin);
- RawPtr<MessagePortArray> portArray = new MessagePortArray;
+ MessagePortArray* portArray = new MessagePortArray;
ArrayBufferArray arrayBufferArray;
ImageBitmapArray imageBitmapArray;
int targetOriginArgIndex = 1;
@@ -210,11 +210,11 @@ void V8Window::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>
}
TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, targetOrigin, info[targetOriginArgIndex]);
- RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], portArray.get(), &arrayBufferArray, &imageBitmapArray, exceptionState);
+ RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instance().create(info.GetIsolate(), info[0], portArray, &arrayBufferArray, &imageBitmapArray, exceptionState);
if (exceptionState.throwIfNeeded())
return;
- window->postMessage(message.release(), portArray.get(), targetOrigin, source, exceptionState);
+ window->postMessage(message.release(), portArray, targetOrigin, source, exceptionState);
exceptionState.throwIfNeeded();
}
@@ -239,11 +239,11 @@ void V8Window::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
// |impl| has to be a LocalDOMWindow, since RemoteDOMWindows wouldn't have
// passed the BindingSecurity check above.
- RawPtr<DOMWindow> openedWindow = toLocalDOMWindow(impl)->open(urlString, frameName, windowFeaturesString, callingDOMWindow(info.GetIsolate()), enteredDOMWindow(info.GetIsolate()));
+ DOMWindow* openedWindow = toLocalDOMWindow(impl)->open(urlString, frameName, windowFeaturesString, callingDOMWindow(info.GetIsolate()), enteredDOMWindow(info.GetIsolate()));
if (!openedWindow)
return;
- v8SetReturnValueFast(info, openedWindow.release(), impl);
+ v8SetReturnValueFast(info, openedWindow, impl);
}
// We lazy create interfaces like testRunner and internals on first access
@@ -371,7 +371,7 @@ void V8Window::namedPropertyGetterCustom(v8::Local<v8::Name> name, const v8::Pro
return;
}
- RawPtr<HTMLCollection> items = doc->windowNamedItems(propName);
+ HTMLCollection* items = doc->windowNamedItems(propName);
if (!items->isEmpty()) {
// TODO(esprehn): Firefox doesn't return an HTMLCollection here if there's
// multiple with the same name, but Chrome and Safari does. What's the
@@ -380,7 +380,7 @@ void V8Window::namedPropertyGetterCustom(v8::Local<v8::Name> name, const v8::Pro
v8SetReturnValueFast(info, items->item(0), window);
return;
}
- v8SetReturnValueFast(info, items.release(), window);
+ v8SetReturnValueFast(info, items, window);
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698