third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 1878943003: Remove RawPtr from bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp » ('j') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

index 9d25a576040a6305621c5c916d6236a3b2f90280..d94e3a78a1149d45cbe60b97835e30ca89486705 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -76,8 +76,8 @@ static v8::Local<v8::Value> getItem(HTMLAllCollection* collection, v8::Local<v8:

if (!argument->IsNumber())

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), indexedWithNonNumberFeature);

- RawPtr<Element> result = collection->item(index->Value());

- return toV8(result.release(), info.Holder(), info.GetIsolate());

+ Element* result = collection->item(index->Value());

+ return toV8(result, info.Holder(), info.GetIsolate());

}

void V8HTMLAllCollection::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)