third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h - Issue 1878943003: Remove RawPtr from bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

index ef465d3d2f1007fe9d870f7f8eb88fcfcc1e3f20..3b7dff84b74b68498b627ee8662d33a648944f07 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

@@ -95,9 +95,9 @@ RawPtr<V8EventListener> V8EventListenerList::findOrCreateWrapper(v8::Local<v8::V

if (wrapper)

return wrapper;

- RawPtr<V8EventListener> wrapperPtr = WrapperType::create(object, isAttribute, scriptState);

+ V8EventListener* wrapperPtr = WrapperType::create(object, isAttribute, scriptState);

sof 2016/04/12 07:29:54 (nit: could just as well reuse |wrapper| here.)

if (wrapperPtr)

- V8HiddenValue::setHiddenValue(scriptState, object, wrapperProperty, v8::External::New(isolate, wrapperPtr.get()));

+ V8HiddenValue::setHiddenValue(scriptState, object, wrapperProperty, v8::External::New(isolate, wrapperPtr));

return wrapperPtr;

}