Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
index 901a73831f44c4cf0eb827f20b37b63c7c53521e..9a0d1ec731cbd303c9e71d46574f54ac95adbcd3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
@@ -96,16 +96,16 @@ RawPtr<NodeFilter> toNodeFilter(v8::Local<v8::Value> callback, v8::Local<v8::Obj
{
if (callback->IsNull())
return nullptr;
- RawPtr<NodeFilter> filter = NodeFilter::create();
+ NodeFilter* filter = NodeFilter::create();
- v8::Local<v8::Value> filterWrapper = toV8(filter.get(), creationContext, scriptState->isolate());
+ v8::Local<v8::Value> filterWrapper = toV8(filter, creationContext, scriptState->isolate());
if (filterWrapper.IsEmpty())
return nullptr;
- RawPtr<NodeFilterCondition> condition = V8NodeFilterCondition::create(callback, filterWrapper.As<v8::Object>(), scriptState);
- filter->setCondition(condition.release());
+ NodeFilterCondition* condition = V8NodeFilterCondition::create(callback, filterWrapper.As<v8::Object>(), scriptState);
+ filter->setCondition(condition);
- return filter.release();
+ return filter;
}
bool toBooleanSlow(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)

Powered by Google App Engine
This is Rietveld 408576698