third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp - Issue 1878943003: Remove RawPtr from bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

index a41ebe3c3097e633d6540f4a1b9c25633b6c8562..bdd6199a5dda366cd18205a8d2bd27823dfbea75 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -565,10 +565,6 @@ void ScriptStreamer::notifyFinished(Resource* resource)

m_stream->didFinishLoading();

m_loadingFinished = true;

- // Calling notifyFinishedToClient can result into the upper layers dropping

- // references to ScriptStreamer. Keep it alive until this function ends.

- RawPtr<ScriptStreamer> protect(this);

notifyFinishedToClient();

}