Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 1878943003: Remove RawPtr from bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index 6d50fba54c6621906a0d0b18723924a1317cc59b..8b324818268369b00fcd6fe43fd252378bf5296b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -507,7 +507,7 @@ static v8::Local<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const A
if (!htmlDocument->hasNamedItem(key) && !htmlDocument->hasExtraNamedItem(key))
return v8Undefined();
- RawPtr<DocumentNameCollection> items = htmlDocument->documentNamedItems(key);
+ DocumentNameCollection* items = htmlDocument->documentNamedItems(key);
if (items->isEmpty())
return v8Undefined();
@@ -519,7 +519,7 @@ static v8::Local<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const A
return toV8(frame->domWindow(), creationContext, isolate);
return toV8(element, creationContext, isolate);
}
- return toV8(RawPtr<HTMLCollection>(items.release()), creationContext, isolate);
+ return toV8(RawPtr<HTMLCollection>(items), creationContext, isolate);
sof 2016/04/12 07:29:54 Redundant cast?
}
static void getter(v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info)

Powered by Google App Engine
This is Rietveld 408576698