Throw TypeError if easing string is invalid.

Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

As described in the bug referenced below, we are temporarily exempting
"function (a){return a}" from throwing a TypeError. A TODO is added to
remove this exemption for M54.

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672
Committed: https://crrev.com/84a58b756e4c8c2746cdfc8f326c11f06d0b2865
Cr-Commit-Position: refs/heads/master@{#387250}

[suzyh_UTC10 (ex-contributor), 2016-04-01 05:19:20]

suzyh@chromium.org changed reviewers:
+ dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-01 05:19:33]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 05:19:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/1

[commit-bot: I haz the power, 2016-04-01 06:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:06:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2016-04-01 08:10:33]

On 2016/04/01 at 06:06:59, commit-bot wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Checking the try job failures, but without access to my code at the moment to
try stuff out.
The failure in inspector/animation/animation-timeline.html seems to be genuine,
but because the test has a bug (refers to "step(5, end)" instead of "steps(5,
end)").
I don't know whether the browser_tests, interactive_ui_tests and
webgl_conformance_tests failures are flakes or not; just looking at the code
hasn't yielded any obvious culprits. I'll look into this on Monday.

[suzyh_UTC10 (ex-contributor), 2016-04-04 00:20:24]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 00:20:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/20001

[suzyh_UTC10 (ex-contributor), 2016-04-04 00:27:18]

suzyh@chromium.org changed reviewers:
+ samli@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-04 00:27:30]

+samli for animation-timeline layout test change.

[samli, 2016-04-04 01:01:02]

lgtm for inspector change

[commit-bot: I haz the power, 2016-04-04 01:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 01:05:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-04-05 02:25:21]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 02:25:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/40001

[suzyh_UTC10 (ex-contributor), 2016-04-05 02:53:12]

Looks like browser_tests failures may have been fixed by the latest rebase.

dstockwell PTAL

[commit-bot: I haz the power, 2016-04-05 03:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 03:11:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2016-04-05 04:50:04]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-04-05 04:50:06]

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
(right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp:66:
return timingFunction && string == timingFunction->toString();
It's probably better to EXPECT_EQ here for informative failure messages.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ElementAnimation.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ElementAnimation.h:59:
ASSERT(TimingInput::convert(duration, timing));
ASSERTs don't get compiled into official builds, you must store the return value
separately if you want to assert on it.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/KeyframeEffect.cpp:62:
ASSERT(TimingInput::convert(duration, timing));
ASSERTs don't get compiled into official builds, you must store the return value
separately if you want to assert on it.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/TimingInput.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/TimingInput.h:22: static bool
convert(double duration, Timing& timingOutput);
Why does this need to change? It never returns false.

[suzyh_UTC10 (ex-contributor), 2016-04-05 06:15:01]

On 2016/04/05 at 02:53:12, suzyh wrote:
> Looks like browser_tests failures may have been fixed by the latest rebase.
> 
> dstockwell PTAL

Gah. Misreading a pass for "[trigger] browser_tests" as a pass for
"browser_tests", plus building on the wrong branch in my local code, means I was
totally wrong about this. Ignore this. I'm still investigating.

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:44:09]

Description was changed from

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=
==========

to

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672
==========

[suzyh_UTC10 (ex-contributor), 2016-04-12 07:49:45]

Description was changed from

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672
==========

to

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

As described in the bug referenced below, we are temporarily exempting
"function (a){return a}" from throwing a TypeError. A TODO is added to
remove this exemption for M54.

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672
==========

[suzyh_UTC10 (ex-contributor), 2016-04-12 08:04:23]

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
(right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp:66:
return timingFunction && string == timingFunction->toString();
On 2016/04/05 at 04:50:06, alancutter wrote:
> It's probably better to EXPECT_EQ here for informative failure messages.

Done.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ElementAnimation.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ElementAnimation.h:59:
ASSERT(TimingInput::convert(duration, timing));
On 2016/04/05 at 04:50:06, alancutter wrote:
> ASSERTs don't get compiled into official builds, you must store the return
value separately if you want to assert on it.

Oooh, whoops. Good catch, fixed.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/KeyframeEffect.cpp (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/KeyframeEffect.cpp:62:
ASSERT(TimingInput::convert(duration, timing));
On 2016/04/05 at 04:50:06, alancutter wrote:
> ASSERTs don't get compiled into official builds, you must store the return
value separately if you want to assert on it.

Fixed.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/TimingInput.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/TimingInput.h:22: static bool
convert(double duration, Timing& timingOutput);
On 2016/04/05 at 04:50:06, alancutter wrote:
> Why does this need to change? It never returns false.

It doesn't _need_ to change, but as a user of this API I would expect the two
TimingInput::convert functions to be consistent in this regard.

[suzyh_UTC10 (ex-contributor), 2016-04-12 08:04:29]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 08:04:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/80001

[commit-bot: I haz the power, 2016-04-12 08:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 08:20:28]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[suzyh_UTC10 (ex-contributor), 2016-04-12 08:59:21]

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ElementAnimation.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ElementAnimation.h:59:
ASSERT(TimingInput::convert(duration, timing));
On 2016/04/12 at 08:04:23, suzyh wrote:
> On 2016/04/05 at 04:50:06, alancutter wrote:
> > ASSERTs don't get compiled into official builds, you must store the return
value separately if you want to assert on it.
> 
> Oooh, whoops. Good catch, fixed.

Hmmm, I'm getting a compile failure on
chromeos_amd64-generic_chromium_compile_only_ng:
error: unused variable 'success' [-Werror=unused-variable]
     bool success = TimingInput::convert(duration, timing);

I can rewrite this as
if (!TimingInput::convert(...))
   ASSERT_NOT_REACHED();
but I don't know if this is overkill. I'm also not sure if this is just a quirk
of this bot, because linux_chromium_rel_ng (for instance) compiled fine.

What do you think?

[suzyh_UTC10 (ex-contributor), 2016-04-12 08:59:34]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 08:59:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/100001

[commit-bot: I haz the power, 2016-04-12 09:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 09:16:21]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Timothy Loh, 2016-04-12 13:21:12]

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/ElementAnimation.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/ElementAnimation.h:59:
ASSERT(TimingInput::convert(duration, timing));
On 2016/04/12 08:59:21, suzyh wrote:
> On 2016/04/12 at 08:04:23, suzyh wrote:
> > On 2016/04/05 at 04:50:06, alancutter wrote:
> > > ASSERTs don't get compiled into official builds, you must store the return
> value separately if you want to assert on it.
> > 
> > Oooh, whoops. Good catch, fixed.
> 
> Hmmm, I'm getting a compile failure on
> chromeos_amd64-generic_chromium_compile_only_ng:
> error: unused variable 'success' [-Werror=unused-variable]
>      bool success = TimingInput::convert(duration, timing);
> 
> I can rewrite this as
> if (!TimingInput::convert(...))
>    ASSERT_NOT_REACHED();
> but I don't know if this is overkill. I'm also not sure if this is just a
quirk
> of this bot, because linux_chromium_rel_ng (for instance) compiled fine.
> 
> What do you think?

DCHECK should work (previously this was called ASSERT_UNUSED but with the
impending style merger this has been deprecated in favor of DCHECK)

[suzyh_UTC10 (ex-contributor), 2016-04-13 00:07:11]

On 2016/04/12 at 13:21:12, timloh wrote:
>
https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/ElementAnimation.h (right):
> 
>
https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/ElementAnimation.h:59:
ASSERT(TimingInput::convert(duration, timing));
> On 2016/04/12 08:59:21, suzyh wrote:
> > On 2016/04/12 at 08:04:23, suzyh wrote:
> > > On 2016/04/05 at 04:50:06, alancutter wrote:
> > > > ASSERTs don't get compiled into official builds, you must store the
return
> > value separately if you want to assert on it.
> > > 
> > > Oooh, whoops. Good catch, fixed.
> > 
> > Hmmm, I'm getting a compile failure on
> > chromeos_amd64-generic_chromium_compile_only_ng:
> > error: unused variable 'success' [-Werror=unused-variable]
> >      bool success = TimingInput::convert(duration, timing);
> > 
> > I can rewrite this as
> > if (!TimingInput::convert(...))
> >    ASSERT_NOT_REACHED();
> > but I don't know if this is overkill. I'm also not sure if this is just a
quirk
> > of this bot, because linux_chromium_rel_ng (for instance) compiled fine.
> > 
> > What do you think?
> 
> DCHECK should work (previously this was called ASSERT_UNUSED but with the
impending style merger this has been deprecated in favor of DCHECK)

Thanks, done. I'll run the CQ dry run again and see if that fixes the issue.

[suzyh_UTC10 (ex-contributor), 2016-04-13 00:07:22]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 00:07:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/120001

[alancutter (OOO until 2018), 2016-04-13 00:46:38]

lgtm with nits.

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/TimingInput.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/TimingInput.h:22: static bool
convert(double duration, Timing& timingOutput);
On 2016/04/12 at 08:04:23, suzyh wrote:
> On 2016/04/05 at 04:50:06, alancutter wrote:
> > Why does this need to change? It never returns false.
> 
> It doesn't _need_ to change, but as a user of this API I would expect the two
TimingInput::convert functions to be consistent in this regard.

I think it makes the call sites harder to read. It's not clear why we're
asserting that it must succeed until you look into the definition.

https://codereview.chromium.org/1851003002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp (right):

https://codereview.chromium.org/1851003002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:247: return
nullptr;
Nit: Blink style is to arrange this as:

if (throwTypeError) {
    throw();
    return nullptr;
}
return value;

[commit-bot: I haz the power, 2016-04-13 01:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 01:16:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:47:51]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:48:09]

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/TimingInput.h (right):

https://codereview.chromium.org/1851003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/TimingInput.h:22: static bool
convert(double duration, Timing& timingOutput);
On 2016/04/13 at 00:46:38, alancutter wrote:
> On 2016/04/12 at 08:04:23, suzyh wrote:
> > On 2016/04/05 at 04:50:06, alancutter wrote:
> > > Why does this need to change? It never returns false.
> > 
> > It doesn't _need_ to change, but as a user of this API I would expect the
two TimingInput::convert functions to be consistent in this regard.
> 
> I think it makes the call sites harder to read. It's not clear why we're
asserting that it must succeed until you look into the definition.

OK, sure. I've put it back the way it was.

https://codereview.chromium.org/1851003002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp (right):

https://codereview.chromium.org/1851003002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:247: return
nullptr;
On 2016/04/13 at 00:46:38, alancutter wrote:
> Nit: Blink style is to arrange this as:
> 
> if (throwTypeError) {
>     throw();
>     return nullptr;
> }
> return value;

I was trying to keep the temporary code all together. But now that I think about
it, that would look like this instead:

if (!throwTypeError) {
  return Timing::defaults().timingFunction;
}
exceptionState.throwTypeError( ... );
return nullptr;

What do you think of this option? I think I prefer it, but if it's too much of a
break from standard style, I'm happy to rewrite as you suggested.

[commit-bot: I haz the power, 2016-04-13 01:48:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/160001

[commit-bot: I haz the power, 2016-04-13 02:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 02:56:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:13:36]

On 2016/04/13 at 02:56:49, commit-bot wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

I've fixed a typo in the javascript file used by some chromeos browser_tests,
which fixes most of the failures in linux_chromium_chromeos_rel_ng.

There's one browser_tests failure VideoPlayerBrowserTest.ClickControlButtons
which is failing for me both with and without my patch, so I'm not sure what to
do about it. I'm going to retry the CQ dry run and see if the bot replicates
that finding this time around.

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:15:27]

suzyh@chromium.org changed reviewers:
+ hirono@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:16:06]

+hirono for ui/file_manager js change

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:16:24]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 01:16:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/180001

[hirono, 2016-04-14 02:36:04]

lgtm, thank you for fixing it!

[commit-bot: I haz the power, 2016-04-14 02:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 02:48:13]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-04-14 04:43:17]

suzyh@chromium.org changed reviewers:
+ timloh@chromium.org
- dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-14 04:43:47]

-dstockwell +timloh for Source/core OWNERS approval, since Doug is OOO

[Timothy Loh, 2016-04-14 06:45:09]

On 2016/04/14 04:43:47, suzyh wrote:
> -dstockwell +timloh for Source/core OWNERS approval, since Doug is OOO

lgtm

[suzyh_UTC10 (ex-contributor), 2016-04-14 06:58:15]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-14 06:58:16]

The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1851003002/#ps180001
(title: "Fix "liner"->"linear" typo in ui/file_manager js file")

[commit-bot: I haz the power, 2016-04-14 06:58:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851003002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851003002/180001

[commit-bot: I haz the power, 2016-04-14 07:03:45]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-14 07:04:57]

Description was changed from

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

As described in the bug referenced below, we are temporarily exempting
"function (a){return a}" from throwing a TypeError. A TODO is added to
remove this exemption for M54.

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672
==========

to

==========
Throw TypeError if easing string is invalid.

Currently, if an animation is created with options containing an
invalid value for 'easing', it is ignored and the default easing is
used instead. This patch changes the implementation to throw a
TypeError as specced
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).

As described in the bug referenced below, we are temporarily exempting
"function (a){return a}" from throwing a TypeError. A TODO is added to
remove this exemption for M54.

This patch also adds a layout test animation-effect-timing-easing.html
that is equivalent to the unit test ParseAnimationTimingFunction
in AnimationInputHelpersTest.cpp. This enables the test results to
be compared against those of other browsers. Note that the test is
therefore duplicated because the unit test is not removed.

BUG=601672

Committed: https://crrev.com/84a58b756e4c8c2746cdfc8f326c11f06d0b2865
Cr-Commit-Position: refs/heads/master@{#387250}
==========

[commit-bot: I haz the power, 2016-04-14 07:04:59]

Patchset 10 (id:??) landed as
https://crrev.com/84a58b756e4c8c2746cdfc8f326c11f06d0b2865
Cr-Commit-Position: refs/heads/master@{#387250}