Throw TypeError if easing string is invalid.

third_party/WebKit/Source/core/animation/ElementAnimation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 37 matching lines @@
 class Dictionary;
 
 class ElementAnimation {
     STATIC_ONLY(ElementAnimation);
 public:
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, double duration, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
         if (exceptionState.hadException())
             return 0;
-        return animateInternal(element, effect, TimingInput::convert(duration));
+        Timing timing;
+        ASSERT(TimingInput::convert(duration, timing));

[alancutter (OOO until 2018), 2016/04/05 04:50:06]

ASSERTs don't get compiled into official builds, you must store the return value
separately if you want to assert on it.

[suzyh_UTC10 (ex-contributor), 2016/04/12 08:04:23]

Oooh, whoops. Good catch, fixed.

[suzyh_UTC10 (ex-contributor), 2016/04/12 08:59:21]

Hmmm, I'm getting a compile failure on
chromeos_amd64-generic_chromium_compile_only_ng:
error: unused variable 'success' [-Werror=unused-variable]
     bool success = TimingInput::convert(duration, timing);

I can rewrite this as
if (!TimingInput::convert(...))
   ASSERT_NOT_REACHED();
but I don't know if this is overkill. I'm also not sure if this is just a quirk
of this bot, because linux_chromium_rel_ng (for instance) compiled fine.

What do you think?

[Timothy Loh, 2016/04/12 13:21:12]

DCHECK should work (previously this was called ASSERT_UNUSED but with the
impending style merger this has been deprecated in favor of DCHECK)

+        return animateInternal(element, effect, timing);
     }
 
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, const KeyframeEffectOptions& options, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
-        if (exceptionState.hadException())
+        Timing timing;
+        bool success = TimingInput::convert(options, timing, exceptionState);
+        if (!success || exceptionState.hadException())
             return 0;
 
-        Animation* animation = animateInternal(element, effect, TimingInput::convert(options));
+        Animation* animation = animateInternal(element, effect, timing);
         animation->setId(options.id());
         return animation;
     }
 
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
         if (exceptionState.hadException())
             return 0;
         return animateInternal(element, effect, Timing());
@@ skipping 18 matching lines @@
     static Animation* animateInternal(Element& element, EffectModel* effect, const Timing& timing)
     {
         KeyframeEffect* keyframeEffect = KeyframeEffect::create(&element, effect, timing);
         return element.document().timeline().play(keyframeEffect);
     }
 };
 
 } // namespace blink
 
 #endif // ElementAnimation_h