third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp - Issue 1851003002: Throw TypeError if easing string is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "liner"->"linear" typo in ui/file_manager js file Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

index 57043099884ee086f93082a9feb7575e0faee6b5..e5ecb3400b1e9b0d84c7d27b9c5b03eb5a0b2c72 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

@@ -236,7 +236,8 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedSetters)

EXPECT_EQ("reverse", specified->direction());

EXPECT_EQ("linear", specified->easing());

- specified->setEasing("step-start");

+ specified->setEasing("step-start", exceptionState);

+ ASSERT_FALSE(exceptionState.hadException());

EXPECT_EQ("step-start", specified->easing());

}