Throw TypeError if easing string is invalid.

third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/AnimationInputHelpers.h"
 
+#include "bindings/core/v8/ExceptionState.h"
 #include "core/SVGNames.h"
 #include "core/css/CSSValueList.h"
 #include "core/css/parser/CSSParser.h"
 #include "core/css/resolver/CSSToStyleMap.h"
 #include "core/frame/Deprecation.h"
 #include "core/svg/SVGElement.h"
 #include "core/svg/animation/SVGSMILElement.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace blink {
@@ skipping 178 matching lines @@
     String unprefixedProperty = removeSVGPrefix(property);
     QualifiedName attributeName = svgAttributeName(unprefixedProperty);
     const AttributeNameMap& supportedAttributes = getSupportedAttributes();
     auto iter = supportedAttributes.find(attributeName);
     if (iter == supportedAttributes.end() || !svgElement.propertyFromAttribute(*iter->value))
         return nullptr;
 
     return iter->value;
 }
 
-PassRefPtr<TimingFunction> AnimationInputHelpers::parseTimingFunction(const String& string, Document* document)
+PassRefPtr<TimingFunction> AnimationInputHelpers::parseTimingFunction(const String& string, Document* document, ExceptionState& exceptionState)
 {
-    if (string.isEmpty())
+    if (string.isEmpty()) {
+        exceptionState.throwTypeError("Easing may not be the empty string");
         return nullptr;
+    }
 
     CSSValue* value = CSSParser::parseSingleValue(CSSPropertyTransitionTimingFunction, string);
     if (!value || !value->isValueList()) {
         ASSERT(!value || value->isCSSWideKeyword());
+        bool throwTypeError = true;
         if (document) {
             if (string.startsWith("function")) {
                 // Due to a bug in old versions of the web-animations-next
                 // polyfill, in some circumstances the string passed in here
                 // may be a Javascript function instead of the allowed values
                 // from the spec
                 // (http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
                 // This bug was fixed in
                 // https://github.com/web-animations/web-animations-next/pull/423
                 // and we want to track how often it is still being hit. The
                 // linear case is special because 'linear' is the default value
-                // for easing.
-                if (string == "function (a){return a}")
-                    UseCounter::count(*document, UseCounter::WebAnimationsEasingAsFunctionLinear);
-                else
+                // for easing. See http://crbug.com/601672
+                if (string == "function (a){return a}") {
+                    Deprecation::countDeprecation(*document, UseCounter::WebAnimationsEasingAsFunctionLinear);
+                    throwTypeError = false;
+                } else {
                     UseCounter::count(*document, UseCounter::WebAnimationsEasingAsFunctionOther);
+                }
             }
         }
+        if (throwTypeError) {
+            // TODO(suzyh): This throwTypeError guard and default return value
+            // exists so that the special linear function case above is exempted
+            // from causing TypeErrors. The bool and guard should be removed
+            // after the M53 branch point in July 2016, so that this case will
+            // also throw TypeErrors from M54 onward.
+            exceptionState.throwTypeError("'" + string + "' is not a valid value for easing");
+        } else {
+            return Timing::defaults().timingFunction;
+        }
         return nullptr;

[alancutter (OOO until 2018), 2016/04/13 00:46:38]

Nit: Blink style is to arrange this as:

if (throwTypeError) {
    throw();
    return nullptr;
}
return value;

[suzyh_UTC10 (ex-contributor), 2016/04/13 01:48:09]

I was trying to keep the temporary code all together. But now that I think about
it, that would look like this instead:

if (!throwTypeError) {
  return Timing::defaults().timingFunction;
}
exceptionState.throwTypeError( ... );
return nullptr;

What do you think of this option? I think I prefer it, but if it's too much of a
break from standard style, I'm happy to rewrite as you suggested.

     }
     CSSValueList* valueList = toCSSValueList(value);
-    if (valueList->length() > 1)
+    if (valueList->length() > 1) {
+        exceptionState.throwTypeError("Easing may not be set to a list of values");
         return nullptr;
+    }
     return CSSToStyleMap::mapAnimationTimingFunction(*valueList->item(0), true);
 }
 
 } // namespace blink