Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: third_party/WebKit/Source/core/animation/TimingInput.h

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TimingInput_h 5 #ifndef TimingInput_h
6 #define TimingInput_h 6 #define TimingInput_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/animation/Timing.h" 9 #include "core/animation/Timing.h"
10 #include "wtf/Allocator.h" 10 #include "wtf/Allocator.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class Dictionary; 14 class Dictionary;
15 class ExceptionState;
15 class KeyframeEffectOptions; 16 class KeyframeEffectOptions;
16 17
17 class CORE_EXPORT TimingInput { 18 class CORE_EXPORT TimingInput {
18 STATIC_ONLY(TimingInput); 19 STATIC_ONLY(TimingInput);
19 public: 20 public:
20 static Timing convert(const KeyframeEffectOptions& timingInput); 21 static bool convert(const KeyframeEffectOptions& timingInput, Timing& timing Output, ExceptionState&);
21 static Timing convert(double duration); 22 static bool convert(double duration, Timing& timingOutput);
alancutter (OOO until 2018) 2016/04/05 04:50:06 Why does this need to change? It never returns fal
suzyh_UTC10 (ex-contributor) 2016/04/12 08:04:23 It doesn't _need_ to change, but as a user of this
alancutter (OOO until 2018) 2016/04/13 00:46:38 I think it makes the call sites harder to read. It
suzyh_UTC10 (ex-contributor) 2016/04/13 01:48:09 OK, sure. I've put it back the way it was.
22 23
23 static void setStartDelay(Timing&, double startDelay); 24 static void setStartDelay(Timing&, double startDelay);
24 static void setEndDelay(Timing&, double endDelay); 25 static void setEndDelay(Timing&, double endDelay);
25 static void setFillMode(Timing&, const String& fillMode); 26 static void setFillMode(Timing&, const String& fillMode);
26 static void setIterationStart(Timing&, double iterationStart); 27 static void setIterationStart(Timing&, double iterationStart);
27 static void setIterationCount(Timing&, double iterationCount); 28 static void setIterationCount(Timing&, double iterationCount);
28 static void setIterationDuration(Timing&, double iterationDuration); 29 static void setIterationDuration(Timing&, double iterationDuration);
29 static void setPlaybackRate(Timing&, double playbackRate); 30 static void setPlaybackRate(Timing&, double playbackRate);
30 static void setPlaybackDirection(Timing&, const String& direction); 31 static void setPlaybackDirection(Timing&, const String& direction);
31 static void setTimingFunction(Timing&, const String& timingFunctionString); 32 static bool setTimingFunction(Timing&, const String& timingFunctionString, E xceptionState&);
32 }; 33 };
33 34
34 } // namespace blink 35 } // namespace blink
35 36
36 #endif 37 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698