third_party/WebKit/Source/core/animation/ElementAnimation.h - Issue 1851003002: Throw TypeError if easing string is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimation.h

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "liner"->"linear" typo in ui/file_manager js file Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/EffectInput.cpp ('k') | third_party/WebKit/Source/core/animation/KeyframeEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/ElementAnimation.h

diff --git a/third_party/WebKit/Source/core/animation/ElementAnimation.h b/third_party/WebKit/Source/core/animation/ElementAnimation.h

index eda33d96b1dd86063ee391ef8626c310be1e4293..b1375fdc52a4582cff02acad53a5002eeb9f3fa3 100644

--- a/third_party/WebKit/Source/core/animation/ElementAnimation.h

+++ b/third_party/WebKit/Source/core/animation/ElementAnimation.h

@@ -61,10 +61,12 @@ public:

static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, const KeyframeEffectOptions& options, ExceptionState& exceptionState)

{

EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);

- if (exceptionState.hadException())

+ Timing timing;

+ bool success = TimingInput::convert(options, timing, &element.document(), exceptionState);

+ if (!success || exceptionState.hadException())

return 0;

- Animation* animation = animateInternal(element, effect, TimingInput::convert(options, &element.document()));

+ Animation* animation = animateInternal(element, effect, timing);

animation->setId(options.id());

return animation;

}