Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/core/animation/TimingInput.cpp

Issue 1851003002: Throw TypeError if easing string is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix "liner"->"linear" typo in ui/file_manager js file Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/TimingInput.h" 5 #include "core/animation/TimingInput.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h"
7 #include "core/animation/AnimationInputHelpers.h" 8 #include "core/animation/AnimationInputHelpers.h"
8 #include "core/animation/KeyframeEffectOptions.h" 9 #include "core/animation/KeyframeEffectOptions.h"
9 10
10 namespace blink { 11 namespace blink {
11 12
12 void TimingInput::setStartDelay(Timing& timing, double startDelay) 13 void TimingInput::setStartDelay(Timing& timing, double startDelay)
13 { 14 {
14 if (std::isfinite(startDelay)) 15 if (std::isfinite(startDelay))
15 timing.startDelay = startDelay / 1000; 16 timing.startDelay = startDelay / 1000;
16 else 17 else
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 timing.direction = Timing::PlaybackDirectionReverse; 79 timing.direction = Timing::PlaybackDirectionReverse;
79 } else if (direction == "alternate") { 80 } else if (direction == "alternate") {
80 timing.direction = Timing::PlaybackDirectionAlternate; 81 timing.direction = Timing::PlaybackDirectionAlternate;
81 } else if (direction == "alternate-reverse") { 82 } else if (direction == "alternate-reverse") {
82 timing.direction = Timing::PlaybackDirectionAlternateReverse; 83 timing.direction = Timing::PlaybackDirectionAlternateReverse;
83 } else { 84 } else {
84 timing.direction = Timing::defaults().direction; 85 timing.direction = Timing::defaults().direction;
85 } 86 }
86 } 87 }
87 88
88 void TimingInput::setTimingFunction(Timing& timing, const String& timingFunction String, Document* document) 89 bool TimingInput::setTimingFunction(Timing& timing, const String& timingFunction String, Document* document, ExceptionState& exceptionState)
89 { 90 {
90 if (RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimi ngFunction(timingFunctionString, document)) 91 if (RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimi ngFunction(timingFunctionString, document, exceptionState)) {
91 timing.timingFunction = timingFunction; 92 timing.timingFunction = timingFunction;
92 else 93 return true;
93 timing.timingFunction = Timing::defaults().timingFunction; 94 }
95 return false;
94 } 96 }
95 97
96 Timing TimingInput::convert(const KeyframeEffectOptions& timingInput, Document* document) 98 bool TimingInput::convert(const KeyframeEffectOptions& timingInput, Timing& timi ngOutput, Document* document, ExceptionState& exceptionState)
97 { 99 {
98 Timing result; 100 setStartDelay(timingOutput, timingInput.delay());
101 setEndDelay(timingOutput, timingInput.endDelay());
102 setFillMode(timingOutput, timingInput.fill());
103 setIterationStart(timingOutput, timingInput.iterationStart());
104 setIterationCount(timingOutput, timingInput.iterations());
105 if (timingInput.duration().isUnrestrictedDouble())
106 setIterationDuration(timingOutput, timingInput.duration().getAsUnrestric tedDouble());
107 else
108 setIterationDuration(timingOutput, -1);
109 setPlaybackRate(timingOutput, timingInput.playbackRate());
110 setPlaybackDirection(timingOutput, timingInput.direction());
111 if (!setTimingFunction(timingOutput, timingInput.easing(), document, excepti onState))
112 return false;
99 113
100 setStartDelay(result, timingInput.delay()); 114 timingOutput.assertValid();
101 setEndDelay(result, timingInput.endDelay());
102 setFillMode(result, timingInput.fill());
103 setIterationStart(result, timingInput.iterationStart());
104 setIterationCount(result, timingInput.iterations());
105 if (timingInput.duration().isUnrestrictedDouble())
106 setIterationDuration(result, timingInput.duration().getAsUnrestrictedDou ble());
107 else
108 setIterationDuration(result, -1);
109 setPlaybackRate(result, timingInput.playbackRate());
110 setPlaybackDirection(result, timingInput.direction());
111 setTimingFunction(result, timingInput.easing(), document);
112 115
113 result.assertValid(); 116 return true;
114
115 return result;
116 } 117 }
117 118
118 Timing TimingInput::convert(double duration) 119 Timing TimingInput::convert(double duration)
119 { 120 {
120 Timing result; 121 Timing result;
121 setIterationDuration(result, duration); 122 setIterationDuration(result, duration);
122 return result; 123 return result;
123 } 124 }
124 125
125 } // namespace blink 126 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInput.h ('k') | third_party/WebKit/Source/core/animation/TimingInputTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698