Throw TypeError if easing string is invalid.

third_party/WebKit/Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 107 matching lines @@
                 }
                 if (keyframe->composite() != EffectModel::CompositeReplace) {
                     exceptionState.throwDOMException(NotSupportedError, "Additive animations are not supported.");
                     return nullptr;
                 }
             }
         }
     }
     keyframeEffectModel->forceConversionsToAnimatableValues(element, element.computedStyle());
 
+    ASSERT(!exceptionState.hadException());
     return keyframeEffectModel;
 }
 
 bool exhaustDictionaryIterator(DictionaryIterator& iterator, ExecutionContext* executionContext, ExceptionState& exceptionState, Vector<Dictionary>& result)
 {
     while (iterator.next(executionContext, exceptionState)) {
         Dictionary dictionary;
         if (!iterator.valueAsDictionary(dictionary, exceptionState)) {
             exceptionState.throwTypeError("Keyframes must be objects.");
             return false;
@@ skipping 51 matching lines @@
         }
 
         String compositeString;
         DictionaryHelper::get(keyframeDictionary, "composite", compositeString);
         if (compositeString == "add")
             keyframe->setComposite(EffectModel::CompositeAdd);
         // TODO(alancutter): Support "accumulate" keyframe composition.
 
         String timingFunctionString;
         if (DictionaryHelper::get(keyframeDictionary, "easing", timingFunctionString)) {
-            if (RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(timingFunctionString, &element.document()))
-                keyframe->setEasing(timingFunction);
+            RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(timingFunctionString, &element.document(), exceptionState);
+            if (!timingFunction)
+                return nullptr;
+            keyframe->setEasing(timingFunction);
         }
 
         Vector<String> keyframeProperties;
         keyframeDictionary.getPropertyNames(keyframeProperties);
         for (const auto& property : keyframeProperties) {
             if (property == "offset"
                 || property == "composite"
                 || property == "easing") {
                 continue;
             }
 
             Vector<String> values;
             if (DictionaryHelper::get(keyframeDictionary, property, values)) {
                 exceptionState.throwTypeError("Lists of values not permitted in array-form list of keyframes");
                 return nullptr;
             }
 
             String value;
             DictionaryHelper::get(keyframeDictionary, property, value);
 
             encounteredCompositableProperty |= setKeyframeValue(element, *keyframe.get(), property, value);
         }
         keyframes.append(keyframe);
     }
 
-    if (exceptionState.hadException())
-        return nullptr;
+    ASSERT(!exceptionState.hadException());
 
     return createEffectModelFromKeyframes(element, keyframes, encounteredCompositableProperty, exceptionState);
 }
 
 EffectModel* EffectInput::convertObjectForm(Element& element, const Dictionary& keyframeDictionary, ExceptionState& exceptionState)
 {
     StringKeyframeVector keyframes;
     bool encounteredCompositableProperty = false;
 
     String timingFunctionString;
     RefPtr<TimingFunction> timingFunction = nullptr;
-    if (DictionaryHelper::get(keyframeDictionary, "easing", timingFunctionString))
-        timingFunction = AnimationInputHelpers::parseTimingFunction(timingFunctionString, &element.document());
+    if (DictionaryHelper::get(keyframeDictionary, "easing", timingFunctionString)) {
+        timingFunction = AnimationInputHelpers::parseTimingFunction(timingFunctionString, &element.document(), exceptionState);
+        if (!timingFunction)
+            return nullptr;
+    }
 
     ScriptValue scriptValue;
     bool frameHasOffset = DictionaryHelper::get(keyframeDictionary, "offset", scriptValue) && !scriptValue.isNull();
     double offset = 0.0;
     if (frameHasOffset && !getAndCheckOffset(keyframeDictionary, offset, 0.0, exceptionState))
         return nullptr;
 
     String compositeString;
     DictionaryHelper::get(keyframeDictionary, "composite", compositeString);
 
@@ skipping 32 matching lines @@
                 keyframe->setComposite(EffectModel::CompositeAdd);
             // TODO(alancutter): Support "accumulate" keyframe composition.
 
             encounteredCompositableProperty |= setKeyframeValue(element, *keyframe.get(), property, values[i]);
             keyframes.append(keyframe);
         }
     }
 
     std::sort(keyframes.begin(), keyframes.end(), compareKeyframes);
 
+    ASSERT(!exceptionState.hadException());
+
     return createEffectModelFromKeyframes(element, keyframes, encounteredCompositableProperty, exceptionState);
 }
 
 } // namespace blink