Throw TypeError if easing string is invalid.

third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/AnimationInputHelpers.h"
 
 #include "core/dom/Element.h"
+#include "core/dom/ExceptionCode.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/animation/TimingFunction.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class AnimationAnimationInputHelpersTest : public ::testing::Test {
 public:
     CSSPropertyID keyframeAttributeToCSSProperty(const String& property)
     {
@@ skipping 10 matching lines @@
     void TearDown() override
     {
         document.release();
 #if ENABLE(OILPAN)
         Heap::collectAllGarbage();
 #endif
     }
 
     OwnPtr<DummyPageHolder> pageHolder;
     Persistent<Document> document;
+    TrackExceptionState exceptionState;
 };
 
 TEST_F(AnimationAnimationInputHelpersTest, ParseKeyframePropertyAttributes)
 {
     EXPECT_EQ(CSSPropertyLineHeight, keyframeAttributeToCSSProperty("lineHeight"));
     EXPECT_EQ(CSSPropertyBorderTopWidth, keyframeAttributeToCSSProperty("borderTopWidth"));
     EXPECT_EQ(CSSPropertyWidth, keyframeAttributeToCSSProperty("width"));
     EXPECT_EQ(CSSPropertyFloat, keyframeAttributeToCSSProperty("float"));
     EXPECT_EQ(CSSPropertyFloat, keyframeAttributeToCSSProperty("cssFloat"));
 
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("line-height"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("border-topWidth"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("Width"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("-epub-text-transform"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("EpubTextTransform"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("-internal-marquee-repetition"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("InternalMarqueeRepetition"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("-webkit-filter"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("-webkit-transform"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("webkitTransform"));
     EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("WebkitTransform"));
 }
 
-static bool timingFunctionRoundTrips(const String& string)
+static bool timingFunctionRoundTrips(const String& string, ExceptionState& exceptionState)
 {
-    RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(string);
+    RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(string, exceptionState);
     return timingFunction && string == timingFunction->toString();

[alancutter (OOO until 2018), 2016/04/05 04:50:06]

It's probably better to EXPECT_EQ here for informative failure messages.

[suzyh_UTC10 (ex-contributor), 2016/04/12 08:04:23]

Done.

 }
 
+static void timingFunctionThrows(const String& string, ExceptionState& exceptionState)
+{
+    RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(string, exceptionState);
+    EXPECT_TRUE(exceptionState.hadException());
+    EXPECT_EQ(V8TypeError, exceptionState.code());
+}
+
 TEST_F(AnimationAnimationInputHelpersTest, ParseAnimationTimingFunction)
 {
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("initial"));
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("inherit"));
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("unset"));
+    timingFunctionThrows("", exceptionState);
+    timingFunctionThrows("initial", exceptionState);
+    timingFunctionThrows("inherit", exceptionState);
+    timingFunctionThrows("unset", exceptionState);
 
-    EXPECT_TRUE(timingFunctionRoundTrips("ease"));
-    EXPECT_TRUE(timingFunctionRoundTrips("linear"));
-    EXPECT_TRUE(timingFunctionRoundTrips("ease-in"));
-    EXPECT_TRUE(timingFunctionRoundTrips("ease-out"));
-    EXPECT_TRUE(timingFunctionRoundTrips("ease-in-out"));
-    EXPECT_TRUE(timingFunctionRoundTrips("step-start"));
-    EXPECT_TRUE(timingFunctionRoundTrips("step-middle"));
-    EXPECT_TRUE(timingFunctionRoundTrips("step-end"));
-    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, start)"));
-    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, middle)"));
-    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, end)"));
-    EXPECT_TRUE(timingFunctionRoundTrips("cubic-bezier(0.1, 5, 0.23, 0)"));
+    EXPECT_TRUE(timingFunctionRoundTrips("ease", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("linear", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("ease-in", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("ease-out", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("ease-in-out", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("step-start", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("step-middle", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("step-end", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, start)", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, middle)", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("steps(3, end)", exceptionState));
+    EXPECT_TRUE(timingFunctionRoundTrips("cubic-bezier(0.1, 5, 0.23, 0)", exceptionState));
 
-    EXPECT_EQ("steps(3, end)", AnimationInputHelpers::parseTimingFunction("steps(3)")->toString());
+    EXPECT_EQ("steps(3, end)", AnimationInputHelpers::parseTimingFunction("steps(3)", exceptionState)->toString());
 
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("steps(3, nowhere)"));
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("steps(-3, end)"));
-    EXPECT_EQ(nullptr, AnimationInputHelpers::parseTimingFunction("cubic-bezier(0.1, 0, 4, 0.4)"));
+    timingFunctionThrows("steps(3, nowhere)", exceptionState);
+    timingFunctionThrows("steps(-3, end)", exceptionState);
+    timingFunctionThrows("cubic-bezier(0.1, 0, 4, 0.4)", exceptionState);
 }
 
 } // namespace blink