Rename GetElementValue() to GetDirectObject{By,At}().

Rename GetElementValue() to GetDirectObject{By,At}().

Every time I read this code, I have to make the mental substituion
that "Element value" means "de-ref indirect object", so it might
as well just say so.

BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/bd56755ba86f2d87e24a3cee5cb92aa14a81bb27

[Tom Sepez, 2016-03-29 20:15:13]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-03-29 20:15:14]

Dan, no functional change intended.

[Tom Sepez, 2016-03-29 20:17:19]

On 2016/03/29 20:15:14, Tom Sepez wrote:
> Dan, no functional change intended.

cpdf_dictionary.h and cpdf_array.h are where to start ...

[dsinclair, 2016-03-29 20:45:26]

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:190: int32_t XFA_GetObjectByCount() {
nit: Don't think we want a By here?

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:193: const XFA_ELEMENTINFO*
XFA_GetObjectByByName(const CFX_WideStringC& wsName) {
nit: GetObjectByName

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:213: const XFA_ELEMENTINFO*
XFA_GetObjectByByID(XFA_ELEMENT eName) {
nit: ByBy

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:216: const uint16_t*
XFA_GetObjectByChildren(XFA_ELEMENT eElement, int32_t& iCount) {
nit: Do we want By here?

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:224: const uint8_t*
XFA_GetObjectByAttributes(XFA_ELEMENT eElement,
ditto

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_obj...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_obj...
xfa/fxfa/parser/xfa_object_imp.cpp:895: const XFA_ELEMENTINFO* pElementInfo =
XFA_GetObjectByByName(wsExpression);
ByBy

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:234: static inline void
XFA_FDEExtension_GetObjectByTagNamespaceURI(
Do we want By here?

https://codereview.chromium.org/1841173002/diff/20001/xfa/include/fxfa/fxfa_b...
File xfa/include/fxfa/fxfa_basic.h (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/include/fxfa/fxfa_b...
xfa/include/fxfa/fxfa_basic.h:931: const XFA_ELEMENTINFO*
XFA_GetObjectByByID(XFA_ELEMENT eName);
ByById, heh

[Tom Sepez, 2016-03-29 20:58:13]

Fixed. I think.

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:190: int32_t XFA_GetObjectByCount() {
On 2016/03/29 20:45:25, dsinclair wrote:
> nit: Don't think we want a By here?

Reverted this entire file.

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_doc...
File xfa/fxfa/parser/xfa_document_imp.cpp (right):

https://codereview.chromium.org/1841173002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_imp.cpp:179: const XFA_ELEMENTINFO* pElement =
XFA_GetObjectByByID(eElement);
reverted entire file.

[dsinclair, 2016-03-29 21:00:42]

lgtm

[Tom Sepez, 2016-03-29 21:01:44]

https://codereview.chromium.org/1841173002/diff/40001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.h (right):

https://codereview.chromium.org/1841173002/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:142: void GetObjectBy(unsigned index, CJS_Value&
value);
.... and this is still hosed.

[Tom Sepez, 2016-03-29 21:11:40]

https://codereview.chromium.org/1841173002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp (right):

https://codereview.chromium.org/1841173002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp:742: TEST(PDFArrayTest,
AddReferenceAndGetObjectBy) {
Fixed this.

[Tom Sepez, 2016-03-29 21:12:45]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-03-29 21:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1841173002/#ps80001
(title: "Fix test name")

[commit-bot: I haz the power, 2016-03-29 21:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841173002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841173002/80001

[commit-bot: I haz the power, 2016-03-29 21:51:53]

Description was changed from

==========
Rename GetElementValue() to GetDirectObject{By,At}().

Every time I read this code, I have to make the mental substituion
that "Element value" means "de-ref indirect object", so it might
as well just say so.

BUG=
==========

to

==========
Rename GetElementValue() to GetDirectObject{By,At}().

Every time I read this code, I have to make the mental substituion
that "Element value" means "de-ref indirect object", so it might
as well just say so.

BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/bd56755ba86f2d87e24a3cee5cb92aa14a81...
==========

[commit-bot: I haz the power, 2016-03-29 21:51:54]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/bd56755ba86f2d87e24a3cee5cb92aa14a81...