Rename GetElementValue() to GetDirectObject{By,At}().

fpdfsdk/javascript/JS_Value.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_JAVASCRIPT_JS_VALUE_H_
 #define FPDFSDK_JAVASCRIPT_JS_VALUE_H_
 
 #include <vector>
@@ skipping 121 matching lines @@
  private:
   FX_BOOL m_bIsSetting;
 };
 
 class CJS_Array {
  public:
   CJS_Array(CJS_Runtime* pRuntime);
   virtual ~CJS_Array();
 
   void Attach(v8::Local<v8::Array> pArray);
-  void GetElement(unsigned index, CJS_Value& value);
+  void GetObjectBy(unsigned index, CJS_Value& value);

[Tom Sepez, 2016/03/29 21:01:43]

.... and this is still hosed.

   void SetElement(unsigned index, CJS_Value value);
   int GetLength();
   FX_BOOL IsAttached();
   operator v8::Local<v8::Array>();
 
   CJS_Runtime* GetJSRuntime() const { return m_pJSRuntime; }
 
  private:
   v8::Local<v8::Array> m_pArray;
   CJS_Runtime* m_pJSRuntime;
@@ skipping 68 matching lines @@
 // names as wchar_t string literals corresponding to each positional argument.
 // The result will always contain |nKeywords| value, with unspecified ones
 // being set to type VT_unknown.
 std::vector<CJS_Value> JS_ExpandKeywordParams(
     CJS_Runtime* pRuntime,
     const std::vector<CJS_Value>& originals,
     size_t nKeywords,
     ...);
 
 #endif  // FPDFSDK_JAVASCRIPT_JS_VALUE_H_