Rename GetElementValue() to GetDirectObject{By,At}().

xfa/fxfa/parser/xfa_document_imp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fxfa/fm2js/xfa_fm2jsapi.h"
 #include "xfa/fxfa/parser/xfa_basic_imp.h"
 #include "xfa/fxfa/parser/xfa_docdata.h"
@@ skipping 158 matching lines @@
   }
 }
 CXFA_Node* CXFA_Document::CreateNode(uint32_t dwPacket, XFA_ELEMENT eElement) {
   return CreateNode(XFA_GetPacketByID(dwPacket), eElement);
 }
 CXFA_Node* CXFA_Document::CreateNode(const XFA_PACKETINFO* pPacket,
                                      XFA_ELEMENT eElement) {
   if (pPacket == NULL) {
     return NULL;
   }
-  const XFA_ELEMENTINFO* pElement = XFA_GetElementByID(eElement);
+  const XFA_ELEMENTINFO* pElement = XFA_GetObjectByByID(eElement);

[Tom Sepez, 2016/03/29 20:58:13]

reverted entire file.

   if (pElement && (pElement->dwPackets & pPacket->eName)) {
     CXFA_Node* pNode = new CXFA_Node(this, pPacket->eName, pElement->eName);
     if (pNode) {
       AddPurgeNode(pNode);
     }
     return pNode;
   }
   return NULL;
 }
 void CXFA_Document::AddPurgeNode(CXFA_Node* pNode) {
@@ skipping 242 matching lines @@
               pProtoNode)) {
         continue;
       }
     }
     if (!pProtoNode) {
       continue;
     }
     XFA_ProtoMerge_MergeNode(this, pUseHrefNode, pProtoNode);
   }
 }