core/fpdfapi/fpdf_page/fpdf_page_func.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_func.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix test name Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_func.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_func.cpp b/core/fpdfapi/fpdf_page/fpdf_page_func.cpp

index 0fa2dd7712ade6dcae27391ad98ce5b39cfb2103..7d396ed032678e2b38a3be6ff18582a1197bb4b3 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_func.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_func.cpp

@@ -776,7 +776,7 @@ FX_BOOL CPDF_StitchFunc::v_Init(CPDF_Object* pObj) {

}

m_nOutputs = 0;

for (uint32_t i = 0; i < nSubs; i++) {

- CPDF_Object* pSub = pArray->GetElementValue(i);

+ CPDF_Object* pSub = pArray->GetDirectObjectAt(i);

if (pSub == pObj) {

return FALSE;

}