core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix test name Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

index 73eabf9368401d865e26fa607898d10a9d1fb4d0..82abc35c024ae673938d27a3e4055097ea84b5b3 100644

--- a/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

+++ b/core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h

@@ -31,8 +31,8 @@ class CPDF_Dictionary : public CPDF_Object {

const CPDF_Dictionary* AsDictionary() const override;

size_t GetCount() const { return m_Map.size(); }

- CPDF_Object* GetElement(const CFX_ByteStringC& key) const;

- CPDF_Object* GetElementValue(const CFX_ByteStringC& key) const;

+ CPDF_Object* GetObjectBy(const CFX_ByteStringC& key) const;

+ CPDF_Object* GetDirectObjectBy(const CFX_ByteStringC& key) const;

CFX_ByteString GetStringBy(const CFX_ByteStringC& key) const;

CFX_ByteStringC GetConstStringBy(const CFX_ByteStringC& key) const;

CFX_ByteString GetStringBy(const CFX_ByteStringC& key,