Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: core/fpdfdoc/doc_bookmark.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix test name Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfdoc/doc_basic.cpp ('k') | core/fpdfdoc/doc_form.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h" 10 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 uint32_t CPDF_Bookmark::GetFontStyle() const { 48 uint32_t CPDF_Bookmark::GetFontStyle() const {
49 if (!m_pDict) { 49 if (!m_pDict) {
50 return 0; 50 return 0;
51 } 51 }
52 return m_pDict->GetIntegerBy("F"); 52 return m_pDict->GetIntegerBy("F");
53 } 53 }
54 CFX_WideString CPDF_Bookmark::GetTitle() const { 54 CFX_WideString CPDF_Bookmark::GetTitle() const {
55 if (!m_pDict) { 55 if (!m_pDict) {
56 return CFX_WideString(); 56 return CFX_WideString();
57 } 57 }
58 CPDF_String* pString = ToString(m_pDict->GetElementValue("Title")); 58 CPDF_String* pString = ToString(m_pDict->GetDirectObjectBy("Title"));
59 if (!pString) 59 if (!pString)
60 return CFX_WideString(); 60 return CFX_WideString();
61 61
62 CFX_WideString title = pString->GetUnicodeText(); 62 CFX_WideString title = pString->GetUnicodeText();
63 int len = title.GetLength(); 63 int len = title.GetLength();
64 if (!len) { 64 if (!len) {
65 return CFX_WideString(); 65 return CFX_WideString();
66 } 66 }
67 std::unique_ptr<FX_WCHAR[]> buf(new FX_WCHAR[len]); 67 std::unique_ptr<FX_WCHAR[]> buf(new FX_WCHAR[len]);
68 for (int i = 0; i < len; i++) { 68 for (int i = 0; i < len; i++) {
69 FX_WCHAR w = title[i]; 69 FX_WCHAR w = title[i];
70 buf[i] = w > 0x20 ? w : 0x20; 70 buf[i] = w > 0x20 ? w : 0x20;
71 } 71 }
72 return CFX_WideString(buf.get(), len); 72 return CFX_WideString(buf.get(), len);
73 } 73 }
74 CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const { 74 CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const {
75 if (!m_pDict) 75 if (!m_pDict)
76 return CPDF_Dest(); 76 return CPDF_Dest();
77 77
78 CPDF_Object* pDest = m_pDict->GetElementValue("Dest"); 78 CPDF_Object* pDest = m_pDict->GetDirectObjectBy("Dest");
79 if (!pDest) 79 if (!pDest)
80 return CPDF_Dest(); 80 return CPDF_Dest();
81 if (pDest->IsString() || pDest->IsName()) { 81 if (pDest->IsString() || pDest->IsName()) {
82 CPDF_NameTree name_tree(pDocument, "Dests"); 82 CPDF_NameTree name_tree(pDocument, "Dests");
83 CFX_ByteStringC name = pDest->GetString(); 83 CFX_ByteStringC name = pDest->GetString();
84 return CPDF_Dest(name_tree.LookupNamedDest(pDocument, name)); 84 return CPDF_Dest(name_tree.LookupNamedDest(pDocument, name));
85 } 85 }
86 if (CPDF_Array* pArray = pDest->AsArray()) 86 if (CPDF_Array* pArray = pDest->AsArray())
87 return CPDF_Dest(pArray); 87 return CPDF_Dest(pArray);
88 return CPDF_Dest(); 88 return CPDF_Dest();
89 } 89 }
90 CPDF_Action CPDF_Bookmark::GetAction() const { 90 CPDF_Action CPDF_Bookmark::GetAction() const {
91 if (!m_pDict) { 91 if (!m_pDict) {
92 return CPDF_Action(); 92 return CPDF_Action();
93 } 93 }
94 return CPDF_Action(m_pDict->GetDictBy("A")); 94 return CPDF_Action(m_pDict->GetDictBy("A"));
95 } 95 }
OLDNEW
« no previous file with comments | « core/fpdfdoc/doc_basic.cpp ('k') | core/fpdfdoc/doc_form.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698